From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2499 invoked by alias); 7 Oct 2009 18:51:27 -0000 Received: (qmail 2488 invoked by uid 22791); 7 Oct 2009 18:51:27 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Oct 2009 18:51:18 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id CA4AF2BABE3; Wed, 7 Oct 2009 14:51:16 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id GMTxWnXwxRn2; Wed, 7 Oct 2009 14:51:16 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 858182BAC4B; Wed, 7 Oct 2009 14:51:16 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 7C4D6F589F; Wed, 7 Oct 2009 11:51:10 -0700 (PDT) Date: Wed, 07 Oct 2009 18:51:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch 3/4] Fix hw watchpoints: remove dead code [update] Message-ID: <20091007185110.GS5689@adacore.com> References: <20090817194624.GD10694@host0.dyn.jankratochvil.net> <20091003171059.GC26203@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091003171059.GC26203@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00156.txt.bz2 > 2009-08-17 Jan Kratochvil > > * i386-nat.c (i386_stopped_by_hwbp): Remove. Thanks for taking care of that. From what I can tell, this function has never been used ever since it was introduced in 2001! (for everyone's interest, if you are wondering why we like git so much, git log -p --grep gave me that answer within a couple of minutes:). > gdb/testsuite/ > 2009-10-03 Jan Kratochvil > > * gdb.base/watchpoint-hw.exp: New variable breakline. > (hbreak, continue to break-at-exit after hbreak): New tests. This part is approved. The issue is that the testcase is dependent on another patch which is still pending. You can either merge that patch into the one it depends on, but I'd rather have a separate small testcase for hbreak. That way, if hbreak alone breaks, we only have to look at that, rather than start by isolating the hbreak problem from the rest of the testcase. -- Joel