From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31265 invoked by alias); 6 Oct 2009 15:07:37 -0000 Received: (qmail 31256 invoked by uid 22791); 6 Oct 2009 15:07:37 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 06 Oct 2009 15:07:32 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id E40BD2BAB95; Tue, 6 Oct 2009 11:07:30 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 3gznuW1efg+h; Tue, 6 Oct 2009 11:07:30 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id AE3282BAB25; Tue, 6 Oct 2009 11:07:30 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 5D273F589B; Tue, 6 Oct 2009 08:07:26 -0700 (PDT) Date: Tue, 06 Oct 2009 15:07:00 -0000 From: Joel Brobecker To: Tristan Gingold Cc: gdb-patches ml Subject: Re: [RFA-Darwin]: Add an info key in darwin executable Message-ID: <20091006150726.GH5689@adacore.com> References: <20091005172951.GC5689@adacore.com> <318E2976-DEC2-4ECD-9338-A06F67DE6B5B@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <318E2976-DEC2-4ECD-9338-A06F67DE6B5B@adacore.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00130.txt.bz2 >>> 2009-10-05 Tristan Gingold >>> >>> * darwin-nat.c: Add __TEXT __info_plist content. >>> (darwin_attach_pid): Update error message. >> >> This looks fine to me. It looks safe for the 7.0 branch as well. >> What do you think? > > Yes, this is definitely safe. Great. I checked that change in the 7.0 branch after you checked it in HEAD. -- Joel