From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12366 invoked by alias); 1 Oct 2009 21:28:12 -0000 Received: (qmail 12346 invoked by uid 22791); 1 Oct 2009 21:28:12 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Oct 2009 21:28:07 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D4BD02BABB4; Thu, 1 Oct 2009 17:28:05 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 991RqgjsHSmv; Thu, 1 Oct 2009 17:28:05 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 9CCD42BAB50; Thu, 1 Oct 2009 17:28:05 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 7FC88F593D; Thu, 1 Oct 2009 14:28:02 -0700 (PDT) Date: Thu, 01 Oct 2009 21:28:00 -0000 From: Joel Brobecker To: Pierre Muller Cc: gdb@sourceware.org, gdb-patches@sourceware.org Subject: Re: [RFA] more fixes to testsuite (was RE: GDB 6.8.92 available for testing) Message-ID: <20091001212802.GQ10338@adacore.com> References: <20090930204828.GB31446@adacore.com> <004701ca428e$fa377c50$eea674f0$@u-strasbg.fr> <20091001172928.GE6532@adacore.com> <000c01ca42dd$3f8c37c0$bea4a740$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000c01ca42dd$3f8c37c0$bea4a740$@u-strasbg.fr> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00031.txt.bz2 > PS: the #ifdef __WIN32__ > should probably be replaced by > something that is also defined for > 64-bit windows, no? We're "lucky" in this case, because __WIN32__ happens to be defined on Windows64. > 2009-10-01 Pierre Muller > > * src/gdb/testsuite/gdb.base/shr1.c: Use %p in format string. > * src/gdb/testsuite/gdb.base/unload.c: Avoid warning in fprintf. > * src/gdb/testsuite/gdb.base/watchpoint-solib.c: Idem. I think it would have been simpler to defile a dlerror *function* that returns a string, but this is fine too. -- Joel