From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1891 invoked by alias); 1 Oct 2009 19:40:47 -0000 Received: (qmail 1881 invoked by uid 22791); 1 Oct 2009 19:40:47 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,HK_OBFDOM X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Oct 2009 19:40:39 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D13222BABA1; Thu, 1 Oct 2009 15:40:37 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id m6ZsNKdT7q0k; Thu, 1 Oct 2009 15:40:37 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 949CB2BAB55; Thu, 1 Oct 2009 15:40:37 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id BD3A5F593D; Thu, 1 Oct 2009 12:40:34 -0700 (PDT) Date: Thu, 01 Oct 2009 19:40:00 -0000 From: Joel Brobecker To: Mark Kettenis Cc: ralf.corsepius@rtems.org, gdb-patches@sourceware.org, jan.kratochvil@redhat.com, tromey@redhat.com Subject: Re: GDB 6.8.92 available for testing Message-ID: <20091001194034.GH6532@adacore.com> References: <20090930204828.GB31446@adacore.com> <4AC41F44.1040502@rtems.org> <20091001170744.GC6532@adacore.com> <4AC4E4F6.5080500@rtems.org> <200910011733.n91HXDnX007084@brahms.sibelius.xs4all.nl> <20091001182740.GG6532@adacore.com> <200910011836.n91IacEh027960@brahms.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="AhhlLboLdkugWU4S" Content-Disposition: inline In-Reply-To: <200910011836.n91IacEh027960@brahms.sibelius.xs4all.nl> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00019.txt.bz2 --AhhlLboLdkugWU4S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 672 [switching to gcc-patches] > Given that newer GCC versions get whinier and whinier and that we see > false positives from time to time, I would be in favour of disabling > -Werror for releases. Makes sense to me. I've just committed the following patch on the branch, after having re-built GDB on x86-linux, making sure that -Werror is no longer used by default anymore. (this is the same patch than the one I applied for GDB 6.6 by the way). 2009-10-01 Joel Brobecker * configure.ac: Disable -Werror by default. * configure: Regenerate. I'll update my release procedure/scripts to do the same for future releases. -- Joel --AhhlLboLdkugWU4S Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="werror.diff" Content-length: 1200 Index: configure.ac =================================================================== RCS file: /cvs/src/src/gdb/configure.ac,v retrieving revision 1.106 diff -u -p -r1.106 configure.ac --- configure.ac 10 Sep 2009 03:59:36 -0000 1.106 +++ configure.ac 1 Oct 2009 19:17:55 -0000 @@ -1510,11 +1510,6 @@ AC_ARG_ENABLE(werror, *) AC_MSG_ERROR(bad value ${enableval} for --enable-werror) ;; esac]) -# Enable -Werror by default when using gcc -if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" ; then - ERROR_ON_WARNING=yes -fi - WERROR_CFLAGS="" if test "${ERROR_ON_WARNING}" = yes ; then WERROR_CFLAGS="-Werror" Index: configure =================================================================== RCS file: /cvs/src/src/gdb/configure,v retrieving revision 1.288 diff -u -p -r1.288 configure --- configure 10 Sep 2009 03:59:37 -0000 1.288 +++ configure 1 Oct 2009 19:17:59 -0000 @@ -13067,11 +13067,6 @@ if test "${enable_werror+set}" = set; th fi -# Enable -Werror by default when using gcc -if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" ; then - ERROR_ON_WARNING=yes -fi - WERROR_CFLAGS="" if test "${ERROR_ON_WARNING}" = yes ; then WERROR_CFLAGS="-Werror" --AhhlLboLdkugWU4S--