From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Daniel Jacobowitz <drow@false.org>,
Mark Kettenis <mark.kettenis@xs4all.nl>
Subject: Re: [PATCH/RFC] Signals & single-stepping
Date: Thu, 01 Oct 2009 14:51:00 -0000 [thread overview]
Message-ID: <200910011551.19751.pedro@codesourcery.com> (raw)
In-Reply-To: <20090930162513.GA10304@caradoc.them.org>
On Wednesday 30 September 2009 17:25:13, Daniel Jacobowitz wrote:
> Your patch doesn't reintroduce the problem from the PR, and the new
> tests in interrupt.exp pass on x86_64-linux. I would really love
> someone else to volunteer to review it though - trap_expected confuses
> me horribly. I'd guess this change could lead to hitting (and
> displaying) the breakpoint at the current PC a second time, which is
> undesirable.
Yes, this messes with hit counts, reruns user breakpoint
commands, etc. Even some internal breakpoints don't like to
be re-hit for no reason. E.g., see linux-thread-db.c:check_event
"Cannot get thread event message".
I think the issue is that when stepping over a breakpoint,
for simplicity, GDB always removes all breakpoints. What if
we made it remove only breakpoints at stop_pc?
--
Pedro Alves
next prev parent reply other threads:[~2009-10-01 14:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-30 14:41 Mark Kettenis
2009-09-30 16:25 ` Daniel Jacobowitz
2009-10-01 14:51 ` Pedro Alves [this message]
2009-10-01 16:14 ` Pedro Alves
2009-10-01 16:44 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910011551.19751.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox