From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5982 invoked by alias); 30 Sep 2009 16:25:22 -0000 Received: (qmail 5952 invoked by uid 22791); 30 Sep 2009 16:25:20 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 30 Sep 2009 16:25:15 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 303732BAB6B; Wed, 30 Sep 2009 12:25:14 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id qlt-of2Nn6bM; Wed, 30 Sep 2009 12:25:14 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C77822BAB64; Wed, 30 Sep 2009 12:25:13 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id CBC3BF593D; Wed, 30 Sep 2009 09:25:10 -0700 (PDT) Date: Wed, 30 Sep 2009 16:25:00 -0000 From: Joel Brobecker To: Jonas Maebe Cc: Tom Tromey , Mark Kettenis , gdb-patches ml Subject: Re: [patch] Set calling convention of methods Message-ID: <20090930162510.GE10338@adacore.com> References: <7B6EF4DA-76C8-4D9C-8B9F-94153EF1C4E1@elis.ugent.be> <691B0BA8-C606-42FF-A796-76CC9C31556A@elis.ugent.be> <200904222215.n3MMF0p2006994@brahms.sibelius.xs4all.nl> <19C107AA-5271-4C23-A6D2-AFF75BBAC4E4@elis.ugent.be> <5AA3BCA9-1ECF-446E-8B49-3132F0E470FB@elis.ugent.be> <20090930000225.GA10338@adacore.com> <8F3B6095-4766-432D-ABB5-AB4DAA2D5572@elis.ugent.be> <267A47C4-C452-4EC5-B74E-7C5C26AF227E@elis.ugent.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <267A47C4-C452-4EC5-B74E-7C5C26AF227E@elis.ugent.be> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00951.txt.bz2 > Additionally, I've added a test, because even in my previous new version > I messed up struct returns. This test should prevent that from happening > again. Thanks for doing that, we really like testcases, so I appreciate the effort. > 2009-09-30 Jonas Maebe elis.ugent.be> > > Add support for the "Borland fastcall" calling convention. > > * dwarf2.h: Add DW_CC_GNU_borland_fastcall_i386 constant. > * i386-tdep.c: #include dwarf2.h > (i386_borland_fastcall_push_dummy_call): New. > (i386_push_dummy_generic_call): Renamed i386_push_dummy_call. > (i386_push_dummy_call): New dispatch function that calls > i386_generic_push_dummy_call or i386_push_dummy_borland_fast_call > depending on the calling convention. Overall, this looks OK to me, but Mark seemed interested in reviewing this patch, so please wait for his comments as well. Again, I think that dwarf2.h needs to be approved by binutils - it's probably going to be routine, but you never know. > * gdb.dwarf2/dw2-borland_fastcall.exp: New. > * gdb.dwarf2/dw2-borland_fastcall.S: New. The .S file needs a copyright header. Would you be able to re-generate the file with -dA, by any chance. It makes the DWARF data more readable. Otherwise, no problem, it's already fine as it is. > +if { ![runto_main] } { > + gdb_suppress_tests; > +} We do not use gdb_suppress_tests anymore. runto_main already logs a FAIL if it does not work, so you can simply return -1 for instance. I don't think the return value makes any difference in our context. -- Joel