Re: [patch] Set calling convention of methods

Joel Brobecker
2009-09-30T16:10:16Z

>> As far as I am concerned, I can't see a problem with using DWARF
>> declarations even from stabs.
>
> We could include the dwarf2.h header in the stabs reader and set the
> calling convention to DW_CC_normal in all cases.

That, or explicitly document that calling smash_to_method_type
with a calling_convention=0 means a normal calling convention.
We'd then just add an extra check at the beginning of this function
that translates calling_convention from zero to DW_CC_normal.
My money is on including dwarf2.h from stabsread.c. We do this
from other places, so why not from stabsread.c?

>> This part is maintained by binutils, I believe. You'll need
>> to ask them for approval of this change.
>
> Tom said it came from gcc
> (http://sourceware.org/ml/gdb-patches/2009-04/msg00063.html) and I did
> submit a patch there:
> http://gcc.gnu.org/ml/gcc-patches/2009-04/msg00301.html . I did not get
> any reaction to that patch (and I guess it's not been applied).

That's really strange, because if you look at include/MAINTAINERS:
% cat include/MAINTAINERS
See ../binutils/MAINTAINERS

So, my guess is that this file is maintained by binutils, and that
GCC should stay up to date. If they have local changes there, they
should merge them into binutils so that both copies stay in sync.

> Later on, Tom clarified that he thought that the gdb and gcc versions of
> dwarf2.h should actually be merged into a single copy, but that I
> shouldn't worry about this since the divergence started before my patch:
> http://sourceware.org/ml/gdb-patches/2009-04/msg00099.html

Right, this shouldn't be your problem. But they should welcome your help
if you send patches to make things right again. Double-check with
the binutils people that they indeed "own" that file first.

--
Joel