Re: [patch] Set calling convention of methods

Tom Tromey
2009-04-10T17:34:18Z

>>>>> "Jonas" == Jonas Maebe <jonas.maebe@elis.ugent.be> writes:

Jonas> In attachment is my patch to set the calling convention for methods.

Do you have a copyright assignment on file?

Jonas> Since the calling convention cannot be defined using stabs, I've
Jonas> hardcoded "0" there (which means that nothing changes compared to the
Jonas> past). Maybe that should rather be some constant? If so, where should
Jonas> it be defined?

Yeah, this is a bit gross. AFAICT the calling convention field only
takes values from dwarf. So, I suppose the question is how you plan
to use this information in later patches. If you check the calling
convention in general code then I suppose we will need some generic
set of values here.

Other than this issue, this looks reasonable to me.

Tom