From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1971 invoked by alias); 29 Sep 2009 19:14:10 -0000 Received: (qmail 1963 invoked by uid 22791); 29 Sep 2009 19:14:10 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 29 Sep 2009 19:14:05 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 448F92BAB73; Tue, 29 Sep 2009 15:14:04 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id IYsZlwitHwda; Tue, 29 Sep 2009 15:14:04 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id F039E2BAB75; Tue, 29 Sep 2009 15:14:03 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id A951FF593D; Tue, 29 Sep 2009 12:14:01 -0700 (PDT) Date: Tue, 29 Sep 2009 19:14:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [RFA/commit] ia64: incorrect breakpoint save/restore with L-type instruction at slot 1 Message-ID: <20090929191401.GC6362@adacore.com> References: <20090925204835.GF5077@adacore.com> <20090926215709.GA26221@host0.dyn.jankratochvil.net> <20090929001641.GH9003@adacore.com> <20090929185518.GA598@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090929185518.GA598@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00933.txt.bz2 This is great work, thanks! > gdb/testsuite/ > 2009-09-29 Jan Kratochvil > > * gdb.base/breakpoint-shadow.exp: Move the ia64 part into ... > * gdb.arch/ia64-breakpoint-shadow.exp, ... a new file, with new tests. > * gdb.arch/ia64-breakpoint-shadow.S: New file. Just one nit, I think. Shouldn't we disassemble bundle, rather than main? Pre-approved, HEAD and branch. -- Joel