From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29424 invoked by alias); 29 Sep 2009 17:46:43 -0000 Received: (qmail 29410 invoked by uid 22791); 29 Sep 2009 17:46:42 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 29 Sep 2009 17:46:35 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 193AD2BAB36; Tue, 29 Sep 2009 13:46:34 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id U6ZKX8rN7qfo; Tue, 29 Sep 2009 13:46:34 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C85B72BAADF; Tue, 29 Sep 2009 13:46:33 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 9FB78F593D; Tue, 29 Sep 2009 10:46:31 -0700 (PDT) Date: Tue, 29 Sep 2009 17:46:00 -0000 From: Joel Brobecker To: Ulrich Weigand Cc: Jan Kratochvil , Matt Rice , gdb-patches@sourceware.org Subject: Re: [rfc] Move PC in-range check in objc-lang.c:find_methods (Re: [ia64] Regression) Message-ID: <20090929174631.GB6362@adacore.com> References: <20090929154328.GA15183@host0.dyn.jankratochvil.net> <200909291727.n8THRdfW031402@d12av02.megacenter.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200909291727.n8THRdfW031402@d12av02.megacenter.de.ibm.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00928.txt.bz2 > ChangeLog: > > * objc-lang.c (find_methods): Move function descriptor conversion > and PC in-range check until after basic checks for ObjC symbols. Seems right to me. Note that the counter is really used as a boolean since: as soon as the count is at least 1, we do a full search of our objfile... -- Joel