From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 698 invoked by alias); 29 Sep 2009 16:07:36 -0000 Received: (qmail 687 invoked by uid 22791); 29 Sep 2009 16:07:34 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtagate5.de.ibm.com (HELO mtagate5.de.ibm.com) (195.212.17.165) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 29 Sep 2009 16:07:28 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate5.de.ibm.com (8.13.1/8.13.1) with ESMTP id n8TG7QCd017802 for ; Tue, 29 Sep 2009 16:07:26 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id n8TG7PcM3571724 for ; Tue, 29 Sep 2009 18:07:25 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n8TG7PQ0027271 for ; Tue, 29 Sep 2009 18:07:25 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id n8TG7O3H027260; Tue, 29 Sep 2009 18:07:24 +0200 Message-Id: <200909291607.n8TG7O3H027260@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 29 Sep 2009 18:07:24 +0200 Subject: Re: [ia64] Regression: Re: [rfc] Fix Obj-C method calls on 64-bit PowerPC To: jan.kratochvil@redhat.com (Jan Kratochvil) Date: Tue, 29 Sep 2009 16:07:00 -0000 From: "Ulrich Weigand" Cc: ratmice@gmail.com (Matt Rice), brobecker@adacore.com (Joel Brobecker), gdb-patches@sourceware.org In-Reply-To: <20090929154328.GA15183@host0.dyn.jankratochvil.net> from "Jan Kratochvil" at Sep 29, 2009 05:43:28 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00919.txt.bz2 Jan Kratochvil wrote: > ia64 is now broken, also on the 7.0 branch due to the check-in: > http://sourceware.org/ml/gdb-cvs/2009-09/msg00210.html Huh. Sorry for the breakage ... > Checked that in the ia64 case there is: > > #4 0x40000000005419c0 in find_methods (symtab=0x0, type=0 '\0', class=0x0, category=0x0, selector=0x60000fffff829dc0 "main", syms=0x0, nsym=0x60000fffff829e70, ndebug=0x60000fffff829e6c) at objc-lang.c:1183 > 1183 pc = gdbarch_convert_from_func_ptr_addr (gdbarch, pc, > (gdb) p *msymbol > $6 = {ginfo = {name = 0x6000000000191360 "__data_start", value = {ivalue = 6917529027641085184, block = 0x6000000000000d00, bytes = 0x6000000000000d00
, address = 6917529027641085184, chain = 0x6000000000000d00}, language_specific = {cplus_specific = {demangled_name = 0x0}}, language = language_auto, section = 20, obj_section = 0x6000000000190ec0}, size = 0, filename = 0x60000000001911c0 "../../gcc/config/ia64/crtend.asm", type = mst_data, target_flag_1 = 0, target_flag_2 = 0, hash_next = 0x0, demangled_hash_next = 0x0} > -> value = 0x6000000000000d00 > which fails to be read as <0x6000000000000d04..0x6000000000000d08) is just missing: > Section Headers: > [Nr] Name Type Address Off Size ES Flg Lk Inf Al > [21] .data PROGBITS 6000000000000d00 000d00 000004 00 WA 0 0 4 > [22] .ctors PROGBITS 6000000000000d08 000d08 000010 00 WA 0 0 8 I agree that ia64_convert_from_func_ptr_addr should not error out in such cases, so your patch looks good to me (would have looked good in any case, even without the Obj-C changes) ... Are you going to check it in? > mst_data looks suspicious but on ppc64 case the function descriptor has really > mst_data there: OK, that's probably the core change that triggers the problem. But as you say, on ppc64 we do actually get mst_data minimal symbols for functions (that point to the descriptor) ... > On ia64-rhel5.4-linux-gnu with this patch there are still these regressions: > +FAIL: gdb.base/corefile.exp: print func2::coremaker_local > +FAIL: gdb.base/corefile.exp: backtrace in corefile.exp > +FAIL: gdb.base/corefile.exp: up in corefile.exp > +FAIL: gdb.base/corefile.exp: up in corefile.exp (reinit) > +FAIL: gdb.base/gcore.exp: where in corefile (pattern 1) > +FAIL: gdb.base/gcore.exp: corefile restored general registers > +FAIL: gdb.base/gcore.exp: corefile restored all registers > +FAIL: gdb.base/gcore.exp: capture_command_output failed on print array_func::local_array. > +FAIL: gdb.base/gcore.exp: corefile restored stack array > +FAIL: gdb.base/gcore.exp: corefile restored backtrace > +FAIL: gdb.gdb/selftest.exp: unknown source line after step over ttyarg initialization > +FAIL: gdb.gdb/selftest.exp: step into xmalloc call > +FAIL: gdb.threads/gcore-thread.exp: corefile contains at least two threads > +FAIL: gdb.threads/gcore-thread.exp: a corefile thread is executing thread2 > +FAIL: gdb.threads/gcore-thread.exp: thread2 is current thread in corefile Are these regressions also introduced by my Obj-C patch? That seems really odd to me ... Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com