From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11198 invoked by alias); 29 Sep 2009 00:59:41 -0000 Received: (qmail 11190 invoked by uid 22791); 29 Sep 2009 00:59:40 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.17.166) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 29 Sep 2009 00:59:35 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.13.1/8.13.1) with ESMTP id n8T0xWt0021645 for ; Tue, 29 Sep 2009 00:59:32 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id n8T0xW0X2867244 for ; Tue, 29 Sep 2009 02:59:32 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n8T0xWft008171 for ; Tue, 29 Sep 2009 02:59:32 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id n8T0xVKZ008166; Tue, 29 Sep 2009 02:59:31 +0200 Message-Id: <200909290059.n8T0xVKZ008166@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 29 Sep 2009 02:59:30 +0200 Subject: Re: [rfc] Fix PowerPC displaced stepping regression To: pedro@codesourcery.com (Pedro Alves) Date: Tue, 29 Sep 2009 00:59:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, julian@codesourcery.com (Julian Brown), drow@false.org (Daniel Jacobowitz), brobecker@adacore.com In-Reply-To: <200909282041.28010.pedro@codesourcery.com> from "Pedro Alves" at Sep 28, 2009 08:41:27 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00896.txt.bz2 Pedro Alves wrote: > On Sunday 27 September 2009 22:47:13, Ulrich Weigand wrote: > > + # the the displaced instruction identified by CLOSURE. If false, > > Double "the". Fixed, thanks! > Hmmm, does this mean that a breakpoint at the start of an > atomic sequence instruction wouldn't be displaced stepped properly, > as in, you'd trip on the same issue that happens when stepping over > an atomic sequence without displaced stepping? Yes, that's true. > (If broken, this was already broken before your patch and even > before the regression your patch fixes) Indeed. For now, I'm OK with restoring the state before the regression. The new mechanism should allow fixing this particular corner case as well, I hope, but this will be more involved ... > ( A nice stress test of the displaced stepping support is to run the > whole testsuite with "set displaced-stepping on". ) > > I've now read through the patch carefully, and didn't spot > anything wrong. I think this would be safe for 7.0 as well. OK, thanks for the review! I've now checked in the patch to mainline. I'll wait with checking into the branch until Joel has agreed how we should handle it ... Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com