From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11438 invoked by alias); 29 Sep 2009 00:50:26 -0000 Received: (qmail 11418 invoked by uid 22791); 29 Sep 2009 00:50:24 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtagate4.de.ibm.com (HELO mtagate4.de.ibm.com) (195.212.17.164) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 29 Sep 2009 00:50:19 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate4.de.ibm.com (8.13.1/8.13.1) with ESMTP id n8T0oGEL019528 for ; Tue, 29 Sep 2009 00:50:16 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id n8T0oEWa2617466 for ; Tue, 29 Sep 2009 02:50:15 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n8T0o3vG004593 for ; Tue, 29 Sep 2009 02:50:09 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id n8T0o1dF004541; Tue, 29 Sep 2009 02:50:01 +0200 Message-Id: <200909290050.n8T0o1dF004541@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 29 Sep 2009 02:50:01 +0200 Subject: Re: [rfc] Fix Obj-C method calls on 64-bit PowerPC To: ratmice@gmail.com (Matt Rice) Date: Tue, 29 Sep 2009 00:50:00 -0000 From: "Ulrich Weigand" Cc: brobecker@adacore.com (Joel Brobecker), gdb-patches@sourceware.org In-Reply-To: <8ba6bed40909281541y1d9455fas873a602caf2508fa@mail.gmail.com> from "Matt Rice" at Sep 28, 2009 03:41:49 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00895.txt.bz2 Matt Rice wrote: > On Mon, Sep 28, 2009 at 9:32 AM, Joel Brobecker wro= > te: > >> =A0 =A0 =A0 * eval.c (evaluate_subexp_standard) [OP_OBJC_MSGCALL]: Suppo= > rt > >> =A0 =A0 =A0 platforms that use function descriptors. =A0Prefer to use fu= > nction > >> =A0 =A0 =A0 pointer types instead of function types. > >> =A0 =A0 =A0 * linespec.c (decode_objc): Support function descriptors. = > =A0Fully > >> =A0 =A0 =A0 initialize SAL result. > >> =A0 =A0 =A0 * objc-lang.c (find_methods): Support function descriptors. > >> =A0 =A0 =A0 Do not require function symbol to point to text section. > >> > >> =A0 =A0 =A0 * ppc-sysv-tdep.c (ppc64_sysv_abi_push_dummy_call): When cal= > ling > >> =A0 =A0 =A0 via a function pointer, use the descriptor it point to. > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0^^^^^ points ;-) > > > > Seems fine to me. Given that this fixes SEGVs, we should consider it > > for inclusion in the 7.0 branch. You might want to ask ratmice@gmail.com > > to give it a test before installing on 7.0, but I don't think it would > > buy us much given that you already tested on s390. At least the risk > > is limited to ObjC. > > I ran this and the tests against cvs head on x86-64 > Additionally I did some tests for things by hand that aren't yet > covered by the testsuite > > all seemed fine, thanks for looking into this. Thanks for testing! I've now checked this in to head and branch. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com