Re: gdb.objc/objcdecode.exp test error..

Joel Brobecker
2009-09-24T17:41:59Z

> * gdb.objc/objcdecode.exp: Additional objc tests for 8343.

And finally, review of the changes for this testcase.

> +gdb_test "set multiple-symbols all" ".*" "setup multiple-symbols all"

The .* is unnecessary, gdb_test already does that for you. But harmless.
Still, I'd remove it, though, since we expect no output at all.

> +set name "can hit multiply defined breakpoint on function after main"
> +gdb_continue_to_breakpoint "function multipleDef"
> +set name "can hit multiply defined breakpoint on objc method after main"
> +gdb_continue_to_breakpoint "method multipleDef"

name seems unusued in these two cases? Or did you mean to use it in
the call to gdb_continue_to_breakpoint?

> +setup_kfail "*-*-*" gdb/8343
> +gdb_run_cmd
> +gdb_test "" \
> +"Breakpoint \[0-9\]+, multipleDef \\\(\\\) at .*" \
> +"can hit multiply defined breakpoint on function before main"

I would put the setup_kfail after the gdb_run_cmd, if you don't mind.
That way, it's clear that the kfail is for the gdb_test, not the
gdb_run_cmd.

Pre-approved with the changes requested.

A big thank you for providing the testcases. I'm sure they will help
lots in the future when we actually tackle this issue.

--
Joel