Re: gdb.objc/objcdecode.exp test error..

Matt Rice
2009-09-24T06:48:33Z

On Wed, Sep 23, 2009 at 4:13 PM, Joel Brobecker <brobecker@adacore.com> wrote:
> Matt,
>
>> attached are new tests, and patches for the bug,
>
> I'm only going to look at the testcase patch for now, since it appears
> that the code patches are not ready yet (they fix your issues, but
> at the price of breaking other things, right?). We can work on the
> code patches separately (but, if you don't mind, summarize again what
> the issues are all about, because i'm having a tough time going through
> the scattered emails).

Thats fine

> 2009-03-05  Matt Rice  <ratmice@gmail.com>
>
>        * gdb.objc/objcdecode.exp: Set the multiple symbols found behaviour
>        to ask for the original test. Add tests for the multiple symbols
>        found behaviour of all.
>
>> +do_objc_tests
>
> I know it's not your fault, but it's definitely a misleading name for
> a routine that simple restarts the debugger... Would you mind renaming
> it to something more meaningful? I noticed also that a couple of global
> declarations are not referenced from that routine, and so can be
> removed: objdir and gdb_prompt.
>
> Thanks! :)

np, this is also duplicated in the 2 .exp files,
i should figure out if i can somehow include it from the gdb.objc?

>> +gdb_test "set multiple-symbols all after main" ""
>
> Uh oh, looks like you merged the command being sent to GDB with
> the description of the test :)

oops,

>> +gdb_test_multiple "break multipleDef" $name \
>> +{
>> +  -re "Breakpoint \[0-9\]+ at 0x\[0-9a-f\]+: file .*\r\nBreakpoint \[0-9\]+ at 0x\[0-9a-f\]+: file .*\r\n$gdb_prompt $" { pass $name }
>> +  -re ".*$gdb_prompt $"   { fail $name }
>> +}
>
> The following can be simplified into a simple call to gdb_test, no?
> Also, please consider adding a call to setup_kfail if we expect
> the test to fail with the current sources.  This is true of most if not
> all the tests that are you adding.
>

yeah, I tried to fix all of these in the patch,
there are a couple gdb_test_multiple's left that looks like they need to be.

I also added the setup_kfails, adjusted the existing kfails to use the
bugzilla #.
I will try to remember to go through grep and look for more in testsuite/

well, theres a lot of tests that pass that just involve various setup
for the tests which fail, i think ideally, these would not be tests,
but e.g. if i just do send_gdb
I seem to run into lots of timing issues, i just kfailed the ones that do fail.

ChangeLog is in the git patch header.

> The call to gdb_exit before do_objc_tests is unnecessary.

k

>> +gdb_exit
>> +return 0
>
> I don't think that this is necessary. All scripts do a little bit of
> cleanup before starting the meat of the testcase, so let's not do double
> pollution...

k