From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22664 invoked by alias); 23 Sep 2009 23:13:25 -0000 Received: (qmail 22654 invoked by uid 22791); 23 Sep 2009 23:13:24 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 23 Sep 2009 23:13:21 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 9B3472BAC04; Wed, 23 Sep 2009 19:13:19 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id g+E8eXCFiiQu; Wed, 23 Sep 2009 19:13:19 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 6422E2BAC00; Wed, 23 Sep 2009 19:13:19 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 345CAF594B; Wed, 23 Sep 2009 16:13:17 -0700 (PDT) Date: Wed, 23 Sep 2009 23:13:00 -0000 From: Joel Brobecker To: Matt Rice Cc: gdb-patches@sourceware.org Subject: Re: gdb.objc/objcdecode.exp test error.. Message-ID: <20090923231317.GA18470@adacore.com> References: <8ba6bed40903051731s41c9183aha18af51113f3c0ea@mail.gmail.com> <20090306173345.GI3744@adacore.com> <200903061913.43419.pedro@codesourcery.com> <8ba6bed40903070407q3e91f0ffs6fc67b2b9c329081@mail.gmail.com> <8ba6bed40903080716k3fbeb56t5605aef1864b26a3@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8ba6bed40903080716k3fbeb56t5605aef1864b26a3@mail.gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00733.txt.bz2 Matt, > attached are new tests, and patches for the bug, I'm only going to look at the testcase patch for now, since it appears that the code patches are not ready yet (they fix your issues, but at the price of breaking other things, right?). We can work on the code patches separately (but, if you don't mind, summarize again what the issues are all about, because i'm having a tough time going through the scattered emails). 2009-03-05 Matt Rice * gdb.objc/objcdecode.exp: Set the multiple symbols found behaviour to ask for the original test. Add tests for the multiple symbols found behaviour of all. > +do_objc_tests I know it's not your fault, but it's definitely a misleading name for a routine that simple restarts the debugger... Would you mind renaming it to something more meaningful? I noticed also that a couple of global declarations are not referenced from that routine, and so can be removed: objdir and gdb_prompt. Thanks! :) > +gdb_test "set multiple-symbols all after main" "" Uh oh, looks like you merged the command being sent to GDB with the description of the test :) > +gdb_test_multiple "break multipleDef" $name \ > +{ > + -re "Breakpoint \[0-9\]+ at 0x\[0-9a-f\]+: file .*\r\nBreakpoint \[0-9\]+ at 0x\[0-9a-f\]+: file .*\r\n$gdb_prompt $" { pass $name } > + -re ".*$gdb_prompt $" { fail $name } > +} The following can be simplified into a simple call to gdb_test, no? Also, please consider adding a call to setup_kfail if we expect the test to fail with the current sources. This is true of most if not all the tests that are you adding. > +gdb_exit > +do_objc_tests The call to gdb_exit before do_objc_tests is unnecessary. > +gdb_exit > +return 0 I don't think that this is necessary. All scripts do a little bit of cleanup before starting the meat of the testcase, so let's not do double pollution... -- Joel