From: Daniel Jacobowitz <drow@false.org>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] printing/setting flag register fields
Date: Sun, 20 Sep 2009 18:00:00 -0000 [thread overview]
Message-ID: <20090920180036.GA19867@caradoc.them.org> (raw)
In-Reply-To: <20090918235632.0DDC6843AC@ruffy.mtv.corp.google.com>
On Fri, Sep 18, 2009 at 04:56:32PM -0700, Doug Evans wrote:
> Hi.
>
> Before I go too far down this path, I'm looking for early feedback.
>
> What do folks think?
Just my two cents - flag types were a workaround for GDB's lack of
good pretty-printing facilities. They should be just structs
containing bitfields, with a default pretty-printer. And/or a union
with an accessible integer value. Anywhere that our handling of such
constructs isn't good enough for eflags, it's not good enough for user
code either, and I deal with a lot of code of this nature.
As for bitfield numbering, I think we should use the corresponding
architecture's conventions; I don't know what the m68k complication
is, though.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2009-09-20 18:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-18 23:57 Doug Evans
2009-09-19 7:07 ` Mark Kettenis
2009-09-19 7:38 ` Andreas Schwab
2009-09-20 18:00 ` Daniel Jacobowitz [this message]
2009-09-20 18:35 ` Doug Evans
2009-09-20 20:27 ` Daniel Jacobowitz
2009-09-21 16:43 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090920180036.GA19867@caradoc.them.org \
--to=drow@false.org \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox