Re: Patch: implement new dynamic varobj spec

Vladimir Prus
2009-09-14T11:24:13Z

Tom Tromey wrote:

> This is the long-awaited dynamic varobj patch.
> It implements the spec as described by Vladimir:
>
> http://sourceware.org/ml/gdb/2009-07/msg00088.html
>
> .. with various minor changes we've discussed on that thread and
> elsewhere. I didn't give the follow-up URLs; I think that the doc patch
> ought to be sufficient, and if it isn't, I will fix it up.
>
> This has been in development for quite a while, including testing using
> two different MI consumers (Vladimir's and one by Noam Yorav-Raphael).
>
> There are three outstanding bugs.
>
> * A dynamic varobj bug that I couldn't reproduce
> http://sourceware.org/ml/archer/2009-q3/msg00169.html
>
> * Lazy string printing.
> http://sourceware.org/ml/archer/2009-q3/msg00189.html
> I'm not sure what we'll do about this in the 7.0 timeframe, maybe
> nothing.
>
> * -var-info-path-expression doesn't work
> http://sourceware.org/bugzilla/show_bug.cgi?id=10252
> (I am not sure it can be made to work, I was planning to turn it into
> an error.)
>
>
> This patch needs a doc review.
>
> This patch doesn't apply directly due to the big python renaming.
> You can probably run sed on the patch if you care to try it.

For avoidance of doubt, I think this patch should go in. I plan to read
the doc changes, and glance at the code, but I am fairly confident that this
is overall good.

- Volodya