From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12532 invoked by alias); 18 Sep 2009 20:43:28 -0000 Received: (qmail 12522 invoked by uid 22791); 18 Sep 2009 20:43:27 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 18 Sep 2009 20:43:24 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 844502BAB82; Fri, 18 Sep 2009 16:43:22 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 4-jEgCwszRnQ; Fri, 18 Sep 2009 16:43:22 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 2A4D32BAB72; Fri, 18 Sep 2009 16:43:22 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 748DCF5926; Fri, 18 Sep 2009 13:43:11 -0700 (PDT) Date: Fri, 18 Sep 2009 20:43:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org, Daniel Jacobowitz , Ulrich Weigand , Mark Kettenis , teawater@gmail.com, msnyder@vmware.com Subject: Re: [RFA] Check solib bfd arch Message-ID: <20090918204311.GQ8910@adacore.com> References: <200909181553.45603.pedro@codesourcery.com> <20090918162511.GA25315@caradoc.them.org> <200909181741.43702.pedro@codesourcery.com> <200909181746.03956.pedro@codesourcery.com> <20090918171708.GP8910@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090918171708.GP8910@adacore.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00613.txt.bz2 > > Some targets (e.g. MIPS as of 2006-12-04) don't fully > > implement this, instead always returning NULL or the first > > argument. We detect that case by checking both directions. */ > > > > compat1 = selected->compatible (selected, from_target); > > compat2 = from_target->compatible (from_target, selected); [...] > I will update my patch accordingly... This probably warrants a function, > probably in gdbarch-utils. Actually, I don't think that this will be needed. Regardless of the order we do things, it's always going to return non-null if both architectures are mips, which is the best we can check in that case. -- Joel