From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6965 invoked by alias); 17 Sep 2009 16:05:55 -0000 Received: (qmail 6688 invoked by uid 22791); 17 Sep 2009 16:05:52 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_14,J_CHICKENPOX_91,J_CHICKENPOX_93 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 17 Sep 2009 16:05:48 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 77C1C2BAB82; Thu, 17 Sep 2009 12:05:46 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 22fn2zl+ghOr; Thu, 17 Sep 2009 12:05:46 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id DC7342BAB4D; Thu, 17 Sep 2009 12:05:45 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 2D6C6F592B; Thu, 17 Sep 2009 09:05:37 -0700 (PDT) Date: Thu, 17 Sep 2009 16:05:00 -0000 From: Joel Brobecker To: Pierre Muller , don.lee@sunplusct.com Cc: donlee@sourceware.org, gdb-patches@sourceware.org Subject: Re: [PING] About score-tdep commit Message-ID: <20090917160537.GL8910@adacore.com> References: <20090806102838.12059.qmail@sourceware.org> <000901ca3769$3a261af0$ae7250d0$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <000901ca3769$3a261af0$ae7250d0$@u-strasbg.fr> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00564.txt.bz2 > Branch 7.0 is open now, but no one reacted to this email I sent > where I said that the watchpoint related code for score-tdep is non > functional. Can we leave this as is in 7.0? Thanks for the ping. I was assuming that the score maintainer would be reacting to your message. Perhaps he does not receive emails sent to his sourceware address. Trying on his regular email address... > > > Pierre Muller > ARI maintainer for GDB > > > > > > > > First message: > > Hi Don, > > looking at > http://sourceware.org/gdb/current/ari/ > I found a revival of TARGET_HAS_HARDWARE_WATCHPOINTS > macros, which should not be there. > > your commit of score-tdep.h was apparently approved in march > but you committed it only in august. > In the mean time, the macro > TARGET_HAS_HARDWARE_WATCHPOINTS has been removed > and several other macros have been renamed > TARGET_CAN_USE_HARDWARE_WATCHPOINT => target_can_use_hardware_watchpoint > STOPPED_BY_WATCHPOINT => target_stopped_by_watchpoint > HAVE_CONTINUABLE_HARDWARE_WATCHPOINT => target_have_continuable_watchpoint > TARGET_REGION_OK_FOR_HW_WATCHPOINT => target_region_ok_for_hw_watchpoint > > Thus the current code is not functional. > > All the hardware watchpoint related macros > that you set in score-tdep.c should be replaced by > appropriate entry in a target_ops struct... > > But I saw no target_ops for your system, > thus I don't really know how to fix your code. > Could you try to look into this? > > Pierre Muller > GDB ARI (Awk Regression Index) maintainer > > > > -----Message d'origine----- > > De : gdb-cvs-owner@sourceware.org [mailto:gdb-cvs-owner@sourceware.org] > > De la part de donlee@sourceware.org > > Envoyé : Thursday, August 06, 2009 12:29 PM > > À : gdb-cvs@sourceware.org > > Objet : src/gdb ChangeLog MAINTAINERS NEWS configure.t ... > > > > CVSROOT: /cvs/src > > Module name: src > > Changes by: donlee@sourceware.org 2009-08-06 10:28:38 > > > > Modified files: > > gdb : ChangeLog MAINTAINERS NEWS configure.tgt > > score-tdep.c score-tdep.h > > > > Log message: > > * score-tdep.c: Support a new Sunplus CT S+core variant, S+core > > 3. > > * score-tdep.h: Ditto. > > * NEWS: Ditto. > > * configure.tgt: Test do we have a simulator. > > * MAINTAINERS: Add myself under target score > > > > Patches: > > http://sources.redhat.com/cgi- > > bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.10781&r2=1.10782 > > http://sources.redhat.com/cgi- > > bin/cvsweb.cgi/src/gdb/MAINTAINERS.diff?cvsroot=src&r1=1.422&r2=1.423 > > http://sources.redhat.com/cgi- > > bin/cvsweb.cgi/src/gdb/NEWS.diff?cvsroot=src&r1=1.324&r2=1.325 > > http://sources.redhat.com/cgi- > > bin/cvsweb.cgi/src/gdb/configure.tgt.diff?cvsroot=src&r1=1.223&r2=1.224 > > http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/score- > > tdep.c.diff?cvsroot=src&r1=1.20&r2=1.21 > > http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/score- > > tdep.h.diff?cvsroot=src&r1=1.5&r2=1.6 > -- Joel