From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13471 invoked by alias); 14 Sep 2009 18:21:31 -0000 Received: (qmail 13461 invoked by uid 22791); 14 Sep 2009 18:21:30 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Sep 2009 18:21:27 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 68C4A2BAAB4; Mon, 14 Sep 2009 14:21:25 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ufQnyFtTSs+g; Mon, 14 Sep 2009 14:21:25 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C0DE12BAB29; Mon, 14 Sep 2009 14:21:24 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 529A5F589B; Mon, 14 Sep 2009 11:21:17 -0700 (PDT) Date: Mon, 14 Sep 2009 18:21:00 -0000 From: Joel Brobecker To: Paul Pluzhnikov Cc: Ulrich Weigand , Pierre Muller , Ulrich Weigand , gdb-patches ml , Tom Tromey , Jan Kratochvil , Christian Thalinger Subject: Re: [patch] Speed up find_pc_section Message-ID: <20090914182117.GL8327@adacore.com> References: <8ac60eac0909131447i5a128877q585e3ab4c24f551b@mail.gmail.com> <200909141643.n8EGhjgm021351@d12av02.megacenter.de.ibm.com> <8ac60eac0909141019x77435f40p32f731dfd9df0abc@mail.gmail.com> <20090914173554.GK8327@adacore.com> <8ac60eac0909141110h18959c04r2a08269296909db9@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8ac60eac0909141110h18959c04r2a08269296909db9@mail.gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00432.txt.bz2 > Given this subthread: > > http://sourceware.org/ml/gdb-patches/2009-09/msg00307.html > > I don't believe OBJF_NOT_MAPPED is the right way to go. Neither do I for the long term. I was seeing this as a temporary work-around while the larger design issue is getting worked on. The patch is relatively small and it's easy to get rid of that flag once it becomes OBE. > Given above, I don't think committing/testing the OBJF_NOT_MAPPED patch > is the right way to go -- it's more of a hack then a solution. Agreed. I'm curious as to what the other maintainers think of this approach. I will probably use this patch in AdaCore's tree, but thought that it might be useful to others as well. The complaint is one part of it which I find to be an issue (they will drown any other complaint that we might emit), but there there is a small performance aspect where we skip scanning objfiles that do not need to be scanned. Anyway, let's see what the others think. I'll pursue this further if there is interest. -- Joel