RE: [patch] Speed up find_pc_section

Pierre Muller
2009-09-11T08:41:37Z

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Paul Pluzhnikov
> Envoyé : Friday, September 11, 2009 10:03 AM
> À : Pierre Muller
> Cc : Joel Brobecker; Ulrich Weigand; gdb-patches ml; Tom Tromey; Jan
> Kratochvil
> Objet : Re: [patch] Speed up find_pc_section
>
> On Fri, Sep 11, 2009 at 12:39 AM, Pierre Muller <muller@ics.u-
> strasbg.fr> wrote:
>
> >> All overlaps are removed in filter_overlapping_sections, before the
> >> first binary search is performed.
> >
> >  This is where I get lost:
> > I see no code in filter_overlapping_sections
> > that changes map_size, so how are these overlapping
> > elements removed and what is put in their place?
>
> Ah, that's a bug; thanks for catching it.
> The filter_overlapping_sections was supposed to return 'j', not
> 'map_size'.
Maybe you could alter the complaint so that it becomes
clear which of the two sections is discarded from the mapping?
In your current patch, it isn't obvious.

Pierre Muller
Pascal language support maintainer for GDB