From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18404 invoked by alias); 14 Sep 2009 16:41:40 -0000 Received: (qmail 18393 invoked by uid 22791); 14 Sep 2009 16:41:39 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.17.166) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Sep 2009 16:41:35 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.13.1/8.13.1) with ESMTP id n8EGfWHh007465 for ; Mon, 14 Sep 2009 16:41:32 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id n8EGfW6b2580544 for ; Mon, 14 Sep 2009 18:41:32 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n8EGfV8i019977 for ; Mon, 14 Sep 2009 18:41:32 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id n8EGfUja019965; Mon, 14 Sep 2009 18:41:30 +0200 Message-Id: <200909141641.n8EGfUja019965@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 14 Sep 2009 18:41:30 +0200 Subject: Re: [patch] Speed up find_pc_section To: ppluzhnikov@google.com (Paul Pluzhnikov) Date: Mon, 14 Sep 2009 16:41:00 -0000 From: "Ulrich Weigand" Cc: brobecker@adacore.com (Joel Brobecker), Ulrich.Weigand@de.ibm.com (Ulrich Weigand), gdb-patches@sourceware.org (gdb-patches ml), tromey@redhat.com (Tom Tromey) In-Reply-To: <8ac60eac0909100918y6e5b4738t8ee0d53f110ac4c8@mail.gmail.com> from "Paul Pluzhnikov" at Sep 10, 2009 09:18:24 AM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00409.txt.bz2 Paul Pluzhnikov wrote: > On Tue, Sep 8, 2009 at 10:38 PM, Joel Brobecker wrote: > > > Otherwise, the patch seems fine. I would love some input from Ulrich, > > though. > > Thanks for the review. Attached patch implements your suggestions. > -- > Paul Pluzhnikov > > > 2009-09-10 Paul Pluzhnikov > > *minsyms.c (lookup_minimal_symbol_by_pc_section_1): Assert non-NULL > section. > (lookup_minimal_symbol_by_pc_section): Check for NULL section. > (lookup_minimal_symbol_by_pc): Adjust. This looks good to me as well, thanks! Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com