From: Joel Brobecker <brobecker@adacore.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] move dwarf2_free_objfile to dwarf2_per_objfile_cleanup
Date: Sun, 13 Sep 2009 17:06:00 -0000 [thread overview]
Message-ID: <20090913170618.GC8327@adacore.com> (raw)
In-Reply-To: <20090904235009.5FA8D843B9@localhost>
> 2009-09-04 Doug Evans <dje@google.com>
>
> * symfile.h (dwarf2_free_objfile): Delete.
> * dwarf2read.c (dwarf2_build_psymtabs_hard): Pass dwarf2_per_objfile
> to free_cached_comp_units.
> (free_cached_comp_units): Remove reference to global
> dwarf2_per_objfile, use passed parameter instead.
> (dwarf2_free_objfile): Delete, contents moved to ...
> (dwarf2_per_objfile_cleanup): ... here.
> * coffread.c (coff_symfile_finish): Delete call to dwarf2_free_objfile.
> * elfread.c (elf_symfile_finish): Delete call to dwarf2_free_objfile.
Not really an expert in this area, but does it look like you are
re-reading the per-objfile data a second time when converting from
a psymtab to a symtab? On the plus side, I really find it makes
the code clearer to understand - it's a bit hard to figure out
the lifetime of this global... Was the memory every released before?
(I see two calls to sym_finish, one when free_objfile is called,
and one when reread_symbols is called - these two are not necessarily
called after the symtab has been computed)
--
Joel
prev parent reply other threads:[~2009-09-13 17:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-04 23:50 Doug Evans
2009-09-05 0:08 ` Joel Brobecker
2009-09-05 8:02 ` Jan Kratochvil
2009-09-13 17:06 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090913170618.GC8327@adacore.com \
--to=brobecker@adacore.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox