From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30772 invoked by alias); 11 Sep 2009 21:15:04 -0000 Received: (qmail 30756 invoked by uid 22791); 11 Sep 2009 21:15:03 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Sep 2009 21:14:58 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 059EA2BAB81; Fri, 11 Sep 2009 17:14:57 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id rbwk3HhxxpPn; Fri, 11 Sep 2009 17:14:56 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C11B02BAB10; Fri, 11 Sep 2009 17:14:56 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id E3C66F589B; Fri, 11 Sep 2009 14:14:53 -0700 (PDT) Date: Fri, 11 Sep 2009 21:15:00 -0000 From: Joel Brobecker To: Paul Pluzhnikov Cc: Pierre Muller , Ulrich Weigand , gdb-patches ml , Tom Tromey , Jan Kratochvil Subject: Re: [patch] Speed up find_pc_section Message-ID: <20090911211453.GR20694@adacore.com> References: <20090909055824.GB11738@adacore.com> <8ac60eac0909101036r101263e7qd11c1a69f13008f1@mail.gmail.com> <20090910182952.GK20694@adacore.com> <8ac60eac0909101829g5384d665gdab27526fe95c27c@mail.gmail.com> <000c01ca32ac$0ca9f8b0$25fdea10$@u-strasbg.fr> <8ac60eac0909110029q1c88dcetdb644fa461fa545c@mail.gmail.com> <000f01ca32b3$0e6b5390$2b41fab0$@u-strasbg.fr> <8ac60eac0909110103l2b88dc95i2f3c238aa4be2ed0@mail.gmail.com> <001201ca32ba$f9060e70$eb122b50$@u-strasbg.fr> <8ac60eac0909111047r1e9f2115u863e250d1c402534@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8ac60eac0909111047r1e9f2115u863e250d1c402534@mail.gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00339.txt.bz2 > 2009-09-11 Paul Pluzhnikov > > * objfiles.c (qsort_cmp): Remove asserts. > (insert_section_p, filter_debuginfo_sections): New function. > (filter_overlapping_sections): Likewise. > (update_section_map): Adjust. Looks great to me. Please go ahead and commit. > + complaint (&symfile_complaints, > + _("unexpected overlap between (A) " > + "section `%s' from `%s' [%s, %s) and (B) " > + "section `%s' from `%s' [%s, %s). " > + "Will ignore section B"), > + bfd_section_name (abfd1, bfds1), objf1->name, > + paddress (gdbarch, sect1_addr), > + paddress (gdbarch, sect1_endaddr), > + bfd_section_name (abfd2, bfds2), objf2->name, > + paddress (gdbarch, sect2_addr), > + paddress (gdbarch, sect2_endaddr)); Just one question: Do you think it might be advantageous to split this complaint in multiple lines? Something like: _("\ unexpected overlap between:\n\ (A) section `%s' from ...\n\ (B) section `%s' from ...\n\ Will ignore section B") Just a thought... If others think so, I will make the change after you commit your patch. You've already gone beyond the call of duty on this one. -- Joel