From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-66707-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 10022 invoked by alias); 11 Sep 2009 07:40:31 -0000
Received: (qmail 10008 invoked by uid 22791); 11 Sep 2009 07:40:30 -0000
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (83.163.83.176)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Sep 2009 07:40:23 +0000
Received: from brahms.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) 	by brahms.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id n8B7dbju006072; 	Fri, 11 Sep 2009 09:39:37 +0200 (CEST)
Received: (from kettenis@localhost) 	by brahms.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id n8B7dbc6028614; 	Fri, 11 Sep 2009 09:39:37 +0200 (CEST)
Date: Fri, 11 Sep 2009 07:40:00 -0000
Message-Id: <200909110739.n8B7dbc6028614@brahms.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: ppluzhnikov@google.com
CC: muller@ics.u-strasbg.fr, brobecker@adacore.com, Ulrich.Weigand@de.ibm.com,         gdb-patches@sourceware.org, tromey@redhat.com,         jan.kratochvil@redhat.com
In-reply-to: <8ac60eac0909110029q1c88dcetdb644fa461fa545c@mail.gmail.com> 	(message from Paul Pluzhnikov on Fri, 11 Sep 2009 00:29:19 -0700)
Subject: Re: [patch] Speed up find_pc_section
References: <8ac60eac0908201340k6b759eb5o9bb73c8f473d8785@mail.gmail.com> 	 <200908211130.n7LBUCJc011108@d12av02.megacenter.de.ibm.com> 	 <8ac60eac0908231548x135edf2doa04fa59a49455bcd@mail.gmail.com> 	 <8ac60eac0908260020l4200cf84v2686a76b5858d13@mail.gmail.com> 	 <20090909055824.GB11738@adacore.com> 	 <8ac60eac0909101036r101263e7qd11c1a69f13008f1@mail.gmail.com> 	 <20090910182952.GK20694@adacore.com> 	 <8ac60eac0909101829g5384d665gdab27526fe95c27c@mail.gmail.com> 	 <000c01ca32ac$0ca9f8b0$25fdea10$@u-strasbg.fr> <8ac60eac0909110029q1c88dcetdb644fa461fa545c@mail.gmail.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-09/txt/msg00302.txt.bz2

> Date: Fri, 11 Sep 2009 00:29:19 -0700
> From: Paul Pluzhnikov <ppluzhnikov@google.com>
> 
>  if (sect1_addr < sect2_addr)
>     return -1;
>   else if (sect1_addr > sect2_addr)
>     return 1;
> 
> -  return 0;
> +  if (sect1->objfile->mtime < sect2->objfile->mtime) return -1;
> +  if (sect1->objfile->mtime > sect2->objfile->mtime) return 1;
> +  return 0;
> }

This snippet caught my eye.  Please put those return statements on a
line of their own.