Hi Eli,

On Saturday 05 September 2009, Eli Zaretskii wrote:
> > +/* Syscall catch.  NEEDED is nonzero if any syscall catch (of any
> > +   kind) is requested.  ANY_COUNT is nonzero if a generic
> > +   (filter-less) syscall catch is being requested.  TABLE is an array
> > +   of ints, indexed by syscall number.  An element in this array is
> > +   nonzero if that syscall should be caught.  TABLE_SIZE is the number
> > +   of elements in TABLE.  */
> > +
> > +#define target_set_syscall_catchpoint(pid, needed, any_count,
> > table_size, table) \ +     (*current_target.to_set_syscall_catchpoint)
> > (pid, needed, any_count, \ +						  table_size, table)
> > +
> 
> Could you perhaps expand the comment a bit more?  For example, what
> should the target do if NEEDED is zero?  Also, I understand that
> ANY_COUNT nonzero means TABLE should be ignored, is that right?
> 
> IOW, imagine that someone is to implement this method, and try to give
> any information necessary to write the code.

I tried to be more descriptive about this piece of code.  I also addressed 
your other message, fixing some wrong comments.  What do you think now?

Thank you for reviewing this,

-- 
Sérgio Durigan Júnior
Linux on Power Toolchain - Software Engineer
Linux Technology Center - LTC
IBM Brazil