From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6403 invoked by alias); 10 Sep 2009 18:30:11 -0000 Received: (qmail 6391 invoked by uid 22791); 10 Sep 2009 18:30:09 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 10 Sep 2009 18:30:03 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 89F6A2BABF2; Thu, 10 Sep 2009 14:30:01 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ydkM1LAiLWbL; Thu, 10 Sep 2009 14:30:01 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 241922BAB8D; Thu, 10 Sep 2009 14:30:01 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id B7C87F5915; Thu, 10 Sep 2009 11:29:52 -0700 (PDT) Date: Thu, 10 Sep 2009 18:30:00 -0000 From: Joel Brobecker To: Paul Pluzhnikov Cc: Ulrich Weigand , Ulrich Weigand , gdb-patches ml , Tom Tromey , Jan Kratochvil Subject: Re: [patch] Speed up find_pc_section Message-ID: <20090910182952.GK20694@adacore.com> References: <8ac60eac0908201340k6b759eb5o9bb73c8f473d8785@mail.gmail.com> <200908211130.n7LBUCJc011108@d12av02.megacenter.de.ibm.com> <8ac60eac0908231548x135edf2doa04fa59a49455bcd@mail.gmail.com> <8ac60eac0908260020l4200cf84v2686a76b5858d13@mail.gmail.com> <20090909055824.GB11738@adacore.com> <8ac60eac0909101036r101263e7qd11c1a69f13008f1@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8ac60eac0909101036r101263e7qd11c1a69f13008f1@mail.gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00276.txt.bz2 > I was wrong (I don't even understand now why I thought that) -- they don't > and this patch doesn't fix MacOS. A separate patch, something like > http://sourceware.org/ml/gdb-patches/2009-08/msg00195.html > is needed. Clever approach, I like it. Are you setup to test this change on MacOS by any chance, now? Otherwise, since MacOS is completely broken, verifying that it helps with any program should be sufficient. In any case, we need to test this patch in a non-MacOS target as well, to test the opposite situation, just in case. Would you mind doing that? If it simplifies things for you, you may check-in the two other pending patches that I reviewed, even if I said to wait for Friday. If there is any objection or issue, it's easy enough to revert or fix. > I am not sure calling complaint rather than warning is really the right > thing here: complaints are silent unless the user explicitly turns them on, > and overlapping sections indicate a real problem of some sort. I still think we should use a complaint in this case. This is still similar to what we do in dwarf2read - we detected a problem with the debugging info, and we emit a complaint. The idea is that, we don't know how many times we're going to encounter that problem, and flooding the user with the same message over something that he probably has little control over is counter productive. > 2009-09-10 Paul Pluzhnikov > > * objfiles.c (qsort_cmp): Remove asserts. > (insert_section_p, filter_debuginfo_sections): New function. > (filter_overlapping_sections): Likewise. > (update_section_map): Adjust. That being said, it's not a very strong opinion, and if you really prefer a warning, please go ahead with this version of the patch. You're fixing the issue on MacOS anyway, so it's making this discussion less important. -- Joel