From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15183 invoked by alias); 10 Sep 2009 07:29:15 -0000 Received: (qmail 15163 invoked by uid 22791); 10 Sep 2009 07:29:13 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 10 Sep 2009 07:29:07 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8A7SQBQ008242; Thu, 10 Sep 2009 03:28:26 -0400 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n8A7SMvI030954 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 10 Sep 2009 03:28:25 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id n8A7SMLq019362; Thu, 10 Sep 2009 09:28:22 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id n8A7SFtY019348; Thu, 10 Sep 2009 09:28:15 +0200 Date: Thu, 10 Sep 2009 07:29:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: Eli Zaretskii , mark.kettenis@xs4all.nl, gdb-patches@sourceware.org, Tom Tromey Subject: Re: [patch] Fix warnings using gcc-4.5 HEAD Message-ID: <20090910072815.GA19270@host0.dyn.jankratochvil.net> References: <20090711082502.GA18801@host0.dyn.jankratochvil.net> <200907110836.n6B8a4Yn015392@brahms.sibelius.xs4all.nl> <20090711083928.GA30826@host0.dyn.jankratochvil.net> <837hyfy3fv.fsf@gnu.org> <20090711175937.GB18892@host0.dyn.jankratochvil.net> <20090908185119.GA10457@host0.dyn.jankratochvil.net> <20090910014821.GH20694@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090910014821.GH20694@adacore.com> User-Agent: Mutt/1.5.19 (2009-01-05) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00273.txt.bz2 On Thu, 10 Sep 2009 03:48:21 +0200, Joel Brobecker wrote: > The Ada part seems fine. I'm left wondering if it really brings much > value to have this in a separate file, rather than added directly to > enum exp_opcode inside expression.h, especially since other languages > are now having visibility on these enumerates. But the the benefits > are not obvious either way to me, so let's not worry about this for now. OK, I (also) do not have a strict opinion on it. > Do you want me to look at the rest of the patch as well, or did someone > (Tom?) look at that already? Except for the changed comment for OP_EXTENDED0 the whole patch is now approved, the other part by Tom: http://sourceware.org/ml/gdb-patches/2009-07/msg00721.html Going to check it in on weekend if nobody replies. Thanks, Jan