From: Joel Brobecker <brobecker@adacore.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
mark.kettenis@xs4all.nl, gdb-patches@sourceware.org,
Tom Tromey <tromey@redhat.com>
Subject: Re: [patch] Fix warnings using gcc-4.5 HEAD
Date: Thu, 10 Sep 2009 01:48:00 -0000 [thread overview]
Message-ID: <20090910014821.GH20694@adacore.com> (raw)
In-Reply-To: <20090908185119.GA10457@host0.dyn.jankratochvil.net>
> > I'd like Joel to comment on the Ada changes.
>
> Hi Joel, pinging for 7.0, this reply is to:
> http://sourceware.org/ml/gdb-patches/2009-07/msg00721.html
The Ada part seems fine. I'm left wondering if it really brings much
value to have this in a separate file, rather than added directly to
enum exp_opcode inside expression.h, especially since other languages
are now having visibility on these enumerates. But the the benefits
are not obvious either way to me, so let's not worry about this for now.
Do you want me to look at the rest of the patch as well, or did someone
(Tom?) look at that already?
--
Joel
next prev parent reply other threads:[~2009-09-10 1:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-11 8:39 Jan Kratochvil
2009-07-11 8:46 ` Mark Kettenis
2009-07-11 9:25 ` Jan Kratochvil
2009-07-11 12:09 ` Eli Zaretskii
2009-07-11 19:02 ` Jan Kratochvil
2009-07-30 0:28 ` Tom Tromey
2009-09-08 18:52 ` Jan Kratochvil
2009-09-10 1:48 ` Joel Brobecker [this message]
2009-09-10 7:29 ` Jan Kratochvil
2009-09-15 16:11 ` Jan Kratochvil
2009-07-11 9:32 ` Eli Zaretskii
2009-07-11 20:58 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090910014821.GH20694@adacore.com \
--to=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=mark.kettenis@xs4all.nl \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox