From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-66591-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 22946 invoked by alias); 8 Sep 2009 06:59:03 -0000
Received: (qmail 22922 invoked by uid 22791); 8 Sep 2009 06:59:02 -0000
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 Sep 2009 06:58:54 +0000
Received: from localhost (localhost.localdomain [127.0.0.1]) 	by filtered-rock.gnat.com (Postfix) with ESMTP id EB48C2BAB58; 	Tue,  8 Sep 2009 02:58:51 -0400 (EDT)
Received: from rock.gnat.com ([127.0.0.1]) 	by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) 	with LMTP id 7b-RdJ9Yoarj; Tue,  8 Sep 2009 02:58:51 -0400 (EDT)
Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) 	by rock.gnat.com (Postfix) with ESMTP id 771392BAB70; 	Tue,  8 Sep 2009 02:58:51 -0400 (EDT)
Received: by joel.gnat.com (Postfix, from userid 1000) 	id 2A28EF589B; Mon,  7 Sep 2009 23:58:44 -0700 (PDT)
Date: Tue, 08 Sep 2009 06:59:00 -0000
From: Joel Brobecker <brobecker@adacore.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>, 	Hui Zhu <teawater@gmail.com>
Subject: Re: [RFA] let record_resume fail immediately on error
Message-ID: <20090908065843.GO30677@adacore.com>
References: <4AA5D713.1060305@vmware.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4AA5D713.1060305@vmware.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-09/txt/msg00186.txt.bz2

>    if (!RECORD_IS_REPLAY)
>      {
>        if (do_record_message (get_current_regcache ()))
> -        {
> -          record_resume_error = 0;
> -        }
> -      else
> -        {
> -          record_resume_error = 1;
> -          return;
> -        }
> +	internal_error (__FILE__, __LINE__, 
> +			_("record_resume: do_record_message failed."));
> +

Forgive me if I'm wrong, as I don't know the record.c code at all, but
I cannot help but think that the internal_error is suspicious here.
Why is this an internal_error?

-- 
Joel