From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29696 invoked by alias); 7 Sep 2009 22:12:09 -0000 Received: (qmail 29685 invoked by uid 22791); 7 Sep 2009 22:12:08 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Sep 2009 22:11:59 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3F2EC2BABAA; Mon, 7 Sep 2009 18:11:57 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id j7hQqgXNVVuJ; Mon, 7 Sep 2009 18:11:57 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id E89822BABA3; Mon, 7 Sep 2009 18:11:56 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 6E7F6F589B; Mon, 7 Sep 2009 15:11:52 -0700 (PDT) Date: Mon, 07 Sep 2009 22:12:00 -0000 From: Joel Brobecker To: Eli Zaretskii Cc: danny.backx@scarlet.be, gdb-patches@sourceware.org Subject: Re: Build question Message-ID: <20090907221152.GL30677@adacore.com> References: <1250931899.11282.142.camel@pavilion> <83skfkfa4n.fsf@gnu.org> <1251095160.16357.352.camel@pavilion> <1251828295.6106.119.camel@pavilion> <83zl9e8nro.fsf@gnu.org> <1251835928.6106.124.camel@pavilion> <83vdk281xb.fsf@gnu.org> <1252143311.6106.252.camel@pavilion> <83eiql4blw.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83eiql4blw.fsf@gnu.org> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00172.txt.bz2 > > +static inline int _isalpha(int c) > > +{ > > + if (c <= 'Z' && c >= 'A') > > + return TRUE; > > + if (c <= 'z' && c >= 'a') > > + return TRUE; > > + return FALSE; > > +} > > I'm not sure what The Powers That Be think about defining inline > functions in a header. As far as I am concerned, I would really like us to avoid them. In this case, is the author trying to achieve performance or to get a behavior that's independent from the locale? -- Joel