From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4076 invoked by alias); 7 Sep 2009 18:33:14 -0000 Received: (qmail 4067 invoked by uid 22791); 7 Sep 2009 18:33:13 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Sep 2009 18:33:06 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3E1572BAB99; Mon, 7 Sep 2009 14:33:04 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id iL+cTUtCog5b; Mon, 7 Sep 2009 14:33:04 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 0AED12BAB98; Mon, 7 Sep 2009 14:33:04 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 95827F589B; Mon, 7 Sep 2009 11:32:59 -0700 (PDT) Date: Mon, 07 Sep 2009 18:33:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] [ia64] Fixup breakpoints errors handling Message-ID: <20090907183259.GH30677@adacore.com> References: <20090905190026.GB16389@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090905190026.GB16389@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00163.txt.bz2 > gdb/ > 2009-09-05 Jan Kratochvil > > * ia64-tdep.c (ia64_memory_insert_breakpoint) > (ia64_memory_remove_breakpoint): Return immediately if any of memory > reads fail. Do not combine the VAL values. The patch is OK. I'm just curious as to which internal_error was triggered? Was it the one inside that function, or did it happen elsewhere? -- Joel