From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21148 invoked by alias); 7 Sep 2009 16:45:59 -0000 Received: (qmail 21124 invoked by uid 22791); 7 Sep 2009 16:45:57 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Sep 2009 16:45:47 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n87GjiUW020030; Mon, 7 Sep 2009 12:45:44 -0400 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n87GjZ0g016668 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 7 Sep 2009 12:45:43 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id n87GjYiu006557; Mon, 7 Sep 2009 18:45:34 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id n87GjSqE006549; Mon, 7 Sep 2009 18:45:28 +0200 Date: Mon, 07 Sep 2009 16:45:00 -0000 From: Jan Kratochvil To: Joel Sherrill Cc: "gdb@sourceware.org" , Ralf Corsepius , gdb-patches@sourceware.org Subject: Re: SPARC GDB Failure Message-ID: <20090907164528.GA6326@host0.dyn.jankratochvil.net> References: <4AA5161D.1020102@oarcorp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AA5161D.1020102@oarcorp.com> User-Agent: Mutt/1.5.19 (2009-01-05) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00156.txt.bz2 On Mon, 07 Sep 2009 16:18:05 +0200, Joel Sherrill wrote: > But sparc/sis core dumps in gdb instantly. It looks as the ia64 crash: http://sourceware.org/ml/gdb-patches/2009-08/msg00221.html I grepped it before but not well enough, now used: $ grep -il 'malloc.*tdep' *.c|xargs grep -il '! *tdep' m68k-tdep.c sparc-tdep.c I think the patch should go in nonetheless and I even hope it fixes it. No testing was made. Thanks, Jan gdb/ 2009-09-07 Jan Kratochvil Fix start crash on unitialized memory on m68k and sparc. * m68k-tdep.c (m68k_gdbarch_init): Allocate TDEP as cleared. * sparc-tdep.c (sparc32_gdbarch_init): Allocate TDEP as cleared. Remove explicit clearing of TDEP fields. --- a/gdb/m68k-tdep.c +++ b/gdb/m68k-tdep.c @@ -1160,7 +1160,7 @@ m68k_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) break; } - tdep = xmalloc (sizeof (struct gdbarch_tdep)); + tdep = xzalloc (sizeof (struct gdbarch_tdep)); gdbarch = gdbarch_alloc (&info, tdep); tdep->fpregs_present = has_fp; tdep->flavour = flavour; --- a/gdb/sparc-tdep.c +++ b/gdb/sparc-tdep.c @@ -1377,16 +1377,11 @@ sparc32_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) return arches->gdbarch; /* Allocate space for the new architecture. */ - tdep = XMALLOC (struct gdbarch_tdep); + tdep = XZALLOC (struct gdbarch_tdep); gdbarch = gdbarch_alloc (&info, tdep); tdep->pc_regnum = SPARC32_PC_REGNUM; tdep->npc_regnum = SPARC32_NPC_REGNUM; - tdep->gregset = NULL; - tdep->sizeof_gregset = 0; - tdep->fpregset = NULL; - tdep->sizeof_fpregset = 0; - tdep->plt_entry_size = 0; tdep->step_trap = sparc_step_trap; set_gdbarch_long_double_bit (gdbarch, 128);