From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 776 invoked by alias); 1 Sep 2009 23:24:06 -0000 Received: (qmail 758 invoked by uid 22791); 1 Sep 2009 23:24:05 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Sep 2009 23:23:59 +0000 Received: (qmail 6030 invoked from network); 1 Sep 2009 23:23:58 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 1 Sep 2009 23:23:58 -0000 From: Pedro Alves To: gdb-patches@sourceware.org, Tom Tromey Subject: Re: RFC: DW_OP_call_frame_cfa, again Date: Tue, 01 Sep 2009 23:24:00 -0000 User-Agent: KMail/1.9.10 References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200909020023.57398.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00040.txt.bz2 On Tuesday 01 September 2009 19:08:25, Tom Tromey wrote: > > +/* CFA accesses require a frame. */ > +static CORE_ADDR > +needs_frame_frame_cfa (void *baton) > +{ > + struct needs_frame_baton *nf_baton = baton; > + nf_baton->needs_frame = 1; > + return 1; > +} > + Return type is CORE_ADDR, but it returns 1? On Tuesday 01 September 2009 19:08:25, Tom Tromey wrote: > +/* Return true if the frame unwinder for frame FI is UNWINDER; false > + otherwise. */ > + > +extern int frame_unwinder_is (struct frame_info *fi, > + const struct frame_unwind *unwinder); > +/* Return true if the frame base for frame FI is BASE; false > + otherwise. */ > + > +int > +frame_unwinder_is (struct frame_info *fi, const struct frame_unwind *unwinder) > +{ Stale comment. -- Pedro Alves