From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29592 invoked by alias); 27 Aug 2009 23:39:21 -0000 Received: (qmail 29581 invoked by uid 22791); 27 Aug 2009 23:39:20 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 27 Aug 2009 23:39:12 +0000 Received: from wpaz5.hot.corp.google.com (wpaz5.hot.corp.google.com [172.24.198.69]) by smtp-out.google.com with ESMTP id n7RNdACe016461 for ; Thu, 27 Aug 2009 16:39:10 -0700 Received: from localhost (ruffy.mtv.corp.google.com [172.18.118.116]) by wpaz5.hot.corp.google.com with ESMTP id n7RNd77Y005534 for ; Thu, 27 Aug 2009 16:39:08 -0700 Received: by localhost (Postfix, from userid 67641) id 78A768438A; Thu, 27 Aug 2009 16:39:07 -0700 (PDT) To: gdb-patches@sourceware.org Subject: [commit] Fix comment for free_all_values Message-Id: <20090827233907.78A768438A@localhost> Date: Fri, 28 Aug 2009 00:14:00 -0000 From: dje@google.com (Doug Evans) X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00498.txt.bz2 Hi. free_all_values is called before each command, not after. I changed the comment thusly. I can change the wording however y'all want. 2009-08-27 Doug Evans * value.c (free_all_values): Tweak comment. Index: value.c =================================================================== RCS file: /cvs/src/src/gdb/value.c,v retrieving revision 1.93 diff -u -p -r1.93 value.c --- value.c 19 Aug 2009 13:00:28 -0000 1.93 +++ value.c 27 Aug 2009 23:34:55 -0000 @@ -638,7 +638,8 @@ value_free_to_mark (struct value *mark) } /* Free all the values that have been allocated (except for those released). - Called after each command, successful or not. */ + Call after each command, successful or not. + In practice this is called before each command, which is sufficient. */ void free_all_values (void)