From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5924 invoked by alias); 27 Aug 2009 20:43:06 -0000 Received: (qmail 5916 invoked by uid 22791); 27 Aug 2009 20:43:05 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 27 Aug 2009 20:43:00 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id CBF3B7C09A for ; Thu, 27 Aug 2009 20:42:58 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id A111A1061C for ; Thu, 27 Aug 2009 20:42:58 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1MgloA-0003h8-13 for gdb-patches@sourceware.org; Thu, 27 Aug 2009 16:42:58 -0400 Date: Thu, 27 Aug 2009 20:50:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: Re: Iconv / Solaris Message-ID: <20090827204258.GB13388@caradoc.them.org> Mail-Followup-To: gdb-patches@sourceware.org References: <20090827020639.GA13935@caradoc.them.org> <20090827170851.GA25905@caradoc.them.org> <20090827203609.GA13388@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090827203609.GA13388@caradoc.them.org> User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00494.txt.bz2 On Thu, Aug 27, 2009 at 04:36:09PM -0400, Daniel Jacobowitz wrote: > > If they are not ok, I think we can just add a new setting to > > configure.host. This is simpler to implement. > > I'm not sure how to do this without hardcoding it by platform. If the > user has external libiconv, do we still want a change? Maybe I'm thinking about this wrong... can we determine the encoding of wchar_t somehow that works on Solaris? Something like what we do now with nl_langinfo? Or is it not guaranteed to have any known encoding? I'm lost in the configure maze, but if we don't define PHONY_ICONV, then INTERMEDIATE_CHARSET ought to be host_charset anyway. So the fact that your patch made a difference implies that PHONY_ICONV is defined. So what's failing? Isn't it our *dummy* iconv_open? -- Daniel Jacobowitz CodeSourcery