From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5223 invoked by alias); 24 Aug 2009 09:53:46 -0000 Received: (qmail 5215 invoked by uid 22791); 24 Aug 2009 09:53:45 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 24 Aug 2009 09:53:40 +0000 Received: (qmail 5841 invoked from network); 24 Aug 2009 09:53:38 -0000 Received: from unknown (HELO wind.localnet) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 24 Aug 2009 09:53:38 -0000 From: Vladimir Prus To: tromey@redhat.com Subject: Re: Simplify MI breakpoint setting Date: Mon, 24 Aug 2009 10:55:00 -0000 User-Agent: KMail/1.11.90 (Linux/2.6.24-24-generic; KDE/4.2.90; i686; svn-979530; 2009-06-10) Cc: gdb-patches@sources.redhat.com References: <200908011113.32939.vladimir@codesourcery.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <200908241353.40486.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00383.txt.bz2 On Friday 07 August 2009 Tom Tromey wrote: > >>>>> "Volodya" == Vladimir Prus writes: > > Volodya> Further, set_breakpoint appears to be trivial and useless > Volodya> wrapper over break_command_really. This patch cleans that > Volodya> up. Are breakpoint.{c,h} changes OK? > > I think the point of this is not to expose all the parameters of > break_command_really outside of breakpoint.c. And, progressing recursively, what is the point of not exposing all the parameters of break_command_really? set_breakpoint is only ever used in MI code, and MI code does not mind those 3 extra parameters. - Volodya