From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25901 invoked by alias); 21 Aug 2009 12:36:17 -0000 Received: (qmail 25890 invoked by uid 22791); 21 Aug 2009 12:36:16 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mtagate5.uk.ibm.com (HELO mtagate5.uk.ibm.com) (195.212.29.138) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 21 Aug 2009 12:36:07 +0000 Received: from d06nrmr1806.portsmouth.uk.ibm.com (d06nrmr1806.portsmouth.uk.ibm.com [9.149.39.193]) by mtagate5.uk.ibm.com (8.14.3/8.13.8) with ESMTP id n7LCa0pw455696 for ; Fri, 21 Aug 2009 12:36:00 GMT Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com [9.149.37.212]) by d06nrmr1806.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id n7LCa09J3002582 for ; Fri, 21 Aug 2009 13:36:00 +0100 Received: from d06av01.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av01.portsmouth.uk.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n7LCa0D1016279 for ; Fri, 21 Aug 2009 13:36:00 +0100 Received: from leonard.localnet (dyn-9-152-224-31.boeblingen.de.ibm.com [9.152.224.31]) by d06av01.portsmouth.uk.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n7LCZuxn016229 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 21 Aug 2009 13:36:00 +0100 Message-Id: <200908211236.n7LCZuxn016229@d06av01.portsmouth.uk.ibm.com> From: Ken Werner Subject: Re: [unladen-swallow] Re: [RFA] Add interface for registering JITed code To: Doug Evans , gdb-patches@sourceware.org Date: Fri, 21 Aug 2009 15:17:00 -0000 References: <9a9942200907221615o570e749fh5cb186c1600f159c@mail.gmail.com> <200907301501.17812.thiago.bauermann@gmail.com> <200907311201.28986.thiago.bauermann@gmail.com> <9a9942200907311117r2f5363f8ufde734ce2bbf721a@mail.gmail.com> <25eb677d0908141612v78fb10eet8fef3b29a7856dc7@mail.gmail.com> User-Agent: KNode/4.3.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="nextPart1381334.k2AaJEMDfx" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00342.txt.bz2 --nextPart1381334.k2AaJEMDfx Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7Bit Content-length: 559 Doug Evans wrote: > On Mon, Aug 17, 2009 at 8:29 AM, Tom Tromey wrote: >>>>>>> "Reid" == Reid Kleckner writes: >> >> Tom> I read it a few more times and nothing popped out at me. >> >> Reid> Is it OK if Doug commits it then? >> >> Yes. >> >> Tom >> > > Committed. Thanks. Hi, I noticed the gdb build fails on ppc64 if -Werror is used: gdb/jit.c: In function 'jit_event_handler': gdb/jit.c:417: warning: cast to pointer from integer of different size The attached patch uses paddress for printing the address. -ken --nextPart1381334.k2AaJEMDfx Content-Type: text/x-patch; name="gdb-jit.patch" Content-Transfer-Encoding: 8Bit Content-Disposition: attachment; filename="gdb-jit.patch" Content-length: 709 Index: gdb/jit.c =================================================================== RCS file: /cvs/src/src/gdb/jit.c,v retrieving revision 1.1 diff -u -r1.1 jit.c --- gdb/jit.c 20 Aug 2009 18:02:47 -0000 1.1 +++ gdb/jit.c 21 Aug 2009 12:27:13 -0000 @@ -413,8 +413,8 @@ case JIT_UNREGISTER: objf = jit_find_objf_with_entry_addr (entry_addr); if (objf == NULL) - printf_unfiltered ("Unable to find JITed code entry at address: %p\n", - (void *) entry_addr); + printf_unfiltered ("Unable to find JITed code entry at address: %s\n", + paddress (target_gdbarch, entry_addr)); else jit_unregister_code (objf); --nextPart1381334.k2AaJEMDfx--