From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32010 invoked by alias); 20 Aug 2009 18:22:23 -0000 Received: (qmail 32000 invoked by uid 22791); 20 Aug 2009 18:22:22 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mtagate4.de.ibm.com (HELO mtagate4.de.ibm.com) (195.212.29.153) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 20 Aug 2009 18:22:16 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate4.de.ibm.com (8.14.3/8.13.8) with ESMTP id n7KIM3oi096066 for ; Thu, 20 Aug 2009 18:22:03 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id n7KIM3WW2269334 for ; Thu, 20 Aug 2009 20:22:03 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n7KIM2BR008130 for ; Thu, 20 Aug 2009 20:22:03 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id n7KIM1vZ008118; Thu, 20 Aug 2009 20:22:01 +0200 Message-Id: <200908201822.n7KIM1vZ008118@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Thu, 20 Aug 2009 20:22:01 +0200 Subject: Re: [patch] Speed up find_pc_section To: ppluzhnikov@google.com (Paul Pluzhnikov) Date: Thu, 20 Aug 2009 18:39:00 -0000 From: "Ulrich Weigand" Cc: Ulrich.Weigand@de.ibm.com (Ulrich Weigand), gdb-patches@sourceware.org (gdb-patches ml), tromey@redhat.com (Tom Tromey) In-Reply-To: <8ac60eac0908201057y44de0b84gdf193f2e2a81bc68@mail.gmail.com> from "Paul Pluzhnikov" at Aug 20, 2009 10:57:47 AM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00327.txt.bz2 Paul Pluzhnikov wrote: > Could you please test attached patch? > > I believe it is correct to simply not insert any overlay sections into > the section map. Tested on Linux/x86_64 with no new failures. Unfortunately, this doesn't help. First of all "section_is_mapped" depends on the target's current overlay state, which changes all the time as overlays get swapped in and out. If your section map were to depend on section_is_mapped, it would have to be re-generated every time the overlay state changes. If you want to remove *all* overlay sections, mapped or not, you could attempt to use "section_is_overlay" instead. But that won't work either -- all the overlay routines have a shortcut that says "no" to all such questions before the user actually enabled overlay support. This means that when loading a binary with overlays, you still crash at the assertion before the user even has the chance to give the "overlay auto" command. It used to be the case that you could debug -to some extent- binaries with overlays even in "overlay off" mode, e.g. because GDB does not support the particular overlay manager. I think this should be preserved; at least GDB should not run into assertion failures just because section addresses overlap ... Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com