From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23035 invoked by alias); 19 Aug 2009 02:44:15 -0000 Received: (qmail 23008 invoked by uid 22791); 19 Aug 2009 02:44:14 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 19 Aug 2009 02:44:07 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 6846910928; Wed, 19 Aug 2009 02:44:05 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id 2C9381065D; Wed, 19 Aug 2009 02:44:05 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1Mdb9f-0006y5-Uo; Tue, 18 Aug 2009 22:44:03 -0400 Date: Wed, 19 Aug 2009 05:22:00 -0000 From: Daniel Jacobowitz To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Limit qualified completions Message-ID: <20090819024403.GA26477@caradoc.them.org> Mail-Followup-To: Keith Seitz , gdb-patches@sourceware.org References: <4A8B3BB9.2070105@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A8B3BB9.2070105@redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00300.txt.bz2 On Tue, Aug 18, 2009 at 04:39:37PM -0700, Keith Seitz wrote: > Hi, > > If the user attempts to complete symbols in a class or namespace, > i.e., "complete break foo::", default_make_symbol_completion_list > will return every single known global symbol in the executable. > > This simplistic patch (and test case) "fixes" the problem, limiting > the matches to the appropriate symbols. > > Ok? It seems to me like there must be a bigger problem with the character list; what if foo is a template? -- Daniel Jacobowitz CodeSourcery