From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13117 invoked by alias); 17 Aug 2009 20:12:22 -0000 Received: (qmail 13106 invoked by uid 22791); 17 Aug 2009 20:12:21 -0000 X-SWARE-Spam-Status: No, hits=-1.0 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_63,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.29.155) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 17 Aug 2009 20:12:15 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.14.3/8.13.8) with ESMTP id n7HKCCIS306504 for ; Mon, 17 Aug 2009 20:12:12 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id n7HKCCGw2498590 for ; Mon, 17 Aug 2009 22:12:12 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n7HKCBO3028102 for ; Mon, 17 Aug 2009 22:12:12 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id n7HKCACc028092; Mon, 17 Aug 2009 22:12:10 +0200 Message-Id: <200908172012.n7HKCACc028092@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 17 Aug 2009 22:12:10 +0200 Subject: [commit] Fix reread_symbols crash (Re: [patch] Speed up find_pc_section) To: ppluzhnikov@google.com (Paul Pluzhnikov) Date: Mon, 17 Aug 2009 21:15:00 -0000 From: "Ulrich Weigand" Cc: pedro@codesourcery.com (Pedro Alves), tromey@redhat.com, gdb-patches@sourceware.org In-Reply-To: <8ac60eac0907221205r2dcc27c1l598cd1d9a064f45b@mail.gmail.com> from "Paul Pluzhnikov" at Jul 22, 2009 12:05:10 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00262.txt.bz2 > 2009-07-22 Paul Pluzhnikov > > * objfiles.h (objfiles_changed): New prototype. > * objfiles.c (objfiles_updated_p): Rename to objfiles_changed_p. > (allocate_objfile, free_objfile): Must rebuild section map. > (objfile_relocate): Likewise. > (update_section_map, find_pc_section): Adjust. > (set_objfiles_updated_on_exe_change): Remove. > (set_objfiles_updated_on_solib_activity): Remove. > (_initialize_objfiles): Remove. > (objfiles_changed): New function. > * symfile.c (reread_symbols): Call objfiles_changed. This patch is causing crashes in reread.exp for me, because the stale section list is accessed in breakpoint_re_set called from clear_symtab_users called from reread_symbols *before* objfiles_changed is called. Fixed by the following patch that calls objfiles_changed before reread_symbols. Tested on spu-elf; committed to mainline. Bye, Ulrich ChangeLog: * symfile.c (reread_symbols): Call objfiles_changed *before* calling clear_symtab_users. Index: gdb/symfile.c =================================================================== RCS file: /cvs/src/src/gdb/symfile.c,v retrieving revision 1.242 diff -u -p -r1.242 symfile.c --- gdb/symfile.c 14 Aug 2009 23:35:33 -0000 1.242 +++ gdb/symfile.c 17 Aug 2009 19:46:44 -0000 @@ -2467,13 +2467,13 @@ reread_symbols (void) if (reread_one) { + /* Notify objfiles that we've modified objfile sections. */ + objfiles_changed (); + clear_symtab_users (); /* At least one objfile has changed, so we can consider that the executable we're debugging has changed too. */ observer_notify_executable_changed (); - - /* Notify objfiles that we've modified objfile sections. */ - objfiles_changed (); } } -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com