From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18401 invoked by alias); 17 Aug 2009 19:54:38 -0000 Received: (qmail 18390 invoked by uid 22791); 17 Aug 2009 19:54:38 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtagate3.de.ibm.com (HELO mtagate3.de.ibm.com) (195.212.29.152) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 17 Aug 2009 19:54:30 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate3.de.ibm.com (8.14.3/8.13.8) with ESMTP id n7HJsRDJ238798 for ; Mon, 17 Aug 2009 19:54:27 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id n7HJsRGV2707472 for ; Mon, 17 Aug 2009 21:54:27 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n7HJsQHE012292 for ; Mon, 17 Aug 2009 21:54:27 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id n7HJsPRh012287; Mon, 17 Aug 2009 21:54:25 +0200 Message-Id: <200908171954.n7HJsPRh012287@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 17 Aug 2009 21:54:25 +0200 Subject: Re: [patch] Speed up find_pc_section To: uweigand@de.ibm.com (Ulrich Weigand) Date: Mon, 17 Aug 2009 19:57:00 -0000 From: "Ulrich Weigand" Cc: ppluzhnikov@google.com (Paul Pluzhnikov), tromey@redhat.com (Tom Tromey), gdb-patches@sourceware.org (gdb-patches ml) In-Reply-To: <200908171927.n7HJRYPE029205@d12av02.megacenter.de.ibm.com> from "Ulrich Weigand" at Aug 17, 2009 09:27:34 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00260.txt.bz2 I wrote: > Paul Pluzhnikov wrote: > > > 2009-08-08 Paul Pluzhnikov > > > > * objfiles.c (qsort_cmp): Remove assert. > > (preferred_obj_section): New function. > > (update_section_map): Filter duplicates. > > This patch breaks overlay support: This part also doesn't really work with overlay sections: static int qsort_cmp (const void *a, const void *b) { const struct obj_section *sect1 = *(const struct obj_section **) a; const struct obj_section *sect2 = *(const struct obj_section **) b; const CORE_ADDR sect1_addr = obj_section_addr (sect1); const CORE_ADDR sect2_addr = obj_section_addr (sect2); if (sect1_addr < sect2_addr) { gdb_assert (obj_section_endaddr (sect1) <= sect2_addr); return -1; } else if (sect1_addr > sect2_addr) { gdb_assert (sect1_addr >= obj_section_endaddr (sect2)); return 1; } Section can partially overlap with overlays ... Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com