Re: [patch] MI: Error out on -var-create invalid FRAME-ADDR

[Vladimir Prus <vladimir@codesourcery.com>]

On Monday 10 August 2009 Jan Kratochvil wrote:

> On Mon, 10 Aug 2009 18:54:52 +0200, Vladimir Prus wrote:
> > Jan Kratochvil wrote:
> > 
> > > -      if (innermost_block && fi != NULL)
> > > +      if (innermost_block)
> > > {
> > > +         /* User could specify explicit FRAME-ADDR which was not found but
> > > +            EXPRESSION is frame specific and we would not be able to evaluate
> > > +            it correctly next time.  With VALID_BLOCK set we must also set
> > > +            FRAME and THREAD_ID.  */
> > > +         if (fi == NULL)
> > > +           {
> > > +             fprintf_unfiltered (gdb_stderr, "Failed to find the specified"
> > > +                                 " frame.\n");
> > > +             return NULL;
> > > +           }
> > 
> > Why is this fprintf + NULL return, as opposed to error?
> 
> I had there error before but changed it to match the code several lines above:
> 
>       /* Don't allow variables to be created for types. */
>       if (var->root->exp->elts[0].opcode == OP_TYPE)
> 	{
> 	  do_cleanups (old_chain);
> 	  fprintf_unfiltered (gdb_stderr, "Attempt to use a type name"
> 			      " as an expression.\n");
> 	  return NULL;
> 	}
> +
> mi_gdb_test "-var-create int * int" \
> 	"&\"Attempt to use a type name as an expression.\\\\n\".*\\^error,msg=\"mi_cmd_var_create: unable to create variable object\"" \
> 	"create int"
> 
> Expecting this former case cannot be changed due to MI2 compatibility but I am
> free to change the new error "Failed to find the specified frame." to use
> error().  Check it in with or without error()?

I'd prefer error for all new code. Thanks!

- Volodya