From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8599 invoked by alias); 1 Aug 2009 14:43:53 -0000 Received: (qmail 8591 invoked by uid 22791); 1 Aug 2009 14:43:52 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from qw-out-1920.google.com (HELO qw-out-1920.google.com) (74.125.92.147) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 01 Aug 2009 14:43:45 +0000 Received: by qw-out-1920.google.com with SMTP id 5so1695960qwf.24 for ; Sat, 01 Aug 2009 07:43:43 -0700 (PDT) Received: by 10.224.37.134 with SMTP id x6mr3103409qad.100.1249137823243; Sat, 01 Aug 2009 07:43:43 -0700 (PDT) Received: from hotblack.localnet ([189.4.46.16]) by mx.google.com with ESMTPS id 7sm8636682qwb.20.2009.08.01.07.43.41 (version=SSLv3 cipher=RC4-MD5); Sat, 01 Aug 2009 07:43:42 -0700 (PDT) From: Thiago Jung Bauermann To: gdb-patches@sourceware.org Subject: Re: [unladen-swallow] Re: [RFA] Add interface for registering JITed code Date: Sat, 01 Aug 2009 14:43:00 -0000 User-Agent: KMail/1.11.4 (Linux/2.6.30-1-amd64; KDE/4.2.4; x86_64; ; ) Cc: Reid Kleckner , unladen-swallow@googlegroups.com, Tom Tromey References: <9a9942200907221615o570e749fh5cb186c1600f159c@mail.gmail.com> <200907311201.28986.thiago.bauermann@gmail.com> <9a9942200907311117r2f5363f8ufde734ce2bbf721a@mail.gmail.com> In-Reply-To: <9a9942200907311117r2f5363f8ufde734ce2bbf721a@mail.gmail.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200908011145.07468.thiago.bauermann@gmail.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00004.txt.bz2 Em Sexta-feira 31 Julho 2009 15:17:24 Reid Kleckner escreveu: > On Fri, Jul 31, 2009 at 8:01 AM, Thiago Jung > > I still think that the patch needs to be tested with a core file scenario > > before it is checked in. Since said scenario is similar to attaching to a > > running process, it will likely magically work, though. > > Well, it didn't magically work because the jit_inferior_create_hook > was getting called twice for core files instead of once. What would > happen is that the binary would get loaded, the hook called, there > would be no debug info, the memory would get loaded, it would get > called again, and it would think that it already read the descriptor. > So I made it look for new code every time just in case, and now it > works. That's great. Thanks for fixing this issue. > Here's an updated patch. What else needs to be dealt with? Looks like it just needs the blessing from the GDB powers that be, now. -- []'s Thiago Jung Bauermann