From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-65617-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20709 invoked by alias); 24 Jul 2009 13:25:57 -0000
Received: (qmail 20701 invoked by uid 22791); 24 Jul 2009 13:25:56 -0000
X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 	tests=AWL,BAYES_00,J_CHICKENPOX_42,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 24 Jul 2009 13:25:49 +0000
Received: (qmail 25798 invoked from network); 24 Jul 2009 13:25:47 -0000
Received: from unknown (HELO orlando.local) (pedro@127.0.0.2)   by mail.codesourcery.com with ESMTPA; 24 Jul 2009 13:25:47 -0000
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: [patch] nto-tdep.c - adjust addr_low addr_high
Date: Fri, 24 Jul 2009 15:41:00 -0000
User-Agent: KMail/1.9.10
Cc: Aleksandar Ristovski <aristovski@qnx.com>
References: <h32abf$f65$1@ger.gmane.org>
In-Reply-To: <h32abf$f65$1@ger.gmane.org>
MIME-Version: 1.0
Content-Type: text/plain;   charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200907241425.45805.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-07/txt/msg00596.txt.bz2

On Wednesday 08 July 2009 15:26:55, Aleksandar Ristovski wrote:

> This adjusts so->addr_low and so->addr_high for proper "info 
> sahredlibrary" output.

>   Index: gdb/nto-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/nto-tdep.c,v
> retrieving revision 1.34
> @@ -315,6 +316,10 @@ nto_relocate_section_addresses (struct s
>  
>    sec->addr = nto_truncate_ptr (sec->addr + LM_ADDR (so) - vaddr);
>    sec->endaddr = nto_truncate_ptr (sec->endaddr + LM_ADDR (so) - vaddr);
> +  if (so->addr_low == 0)
> +    so->addr_low = LM_ADDR (so);

Isn't LM_ADDR an offset, not an absolute address?

> +  if (so->addr_high < sec->endaddr)
> +    so->addr_high = sec->endaddr;
>  }
>  
>  /* This is cheating a bit because our linker code is in libc.so.  If we

-- 
Pedro Alves