Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: ppluzhnikov@google.com (Paul Pluzhnikov)
To: gdb-patches@sourceware.org
Cc: ppluzhnikov@google.com
Subject: [patch] Make 'info func' interruptible.
Date: Thu, 23 Jul 2009 12:09:00 -0000	[thread overview]
Message-ID: <20090723015805.BD0F076BC0@localhost> (raw)

Greetings,

This is rather on the obvious side.

For a large (300MB) debug binary, doing 'info func' (without regex)
puts GDB into 10 minute uniterruptible 100% CPU spin.

While improving the 10 minute wait will hopefully be a subject of
another patch, attached patch makes the wait interruptible.

Thanks,
--
Paul Pluzhnikov

2009-07-22  Paul Pluzhnikov  <ppluzhnikov@google.com>

	* symtab.c (search_symbols): Add QUIT.


Index: symtab.c
===================================================================
RCS file: /cvs/src/src/gdb/symtab.c,v
retrieving revision 1.213
diff -u -p -u -r1.213 symtab.c
--- symtab.c	2 Jul 2009 17:21:07 -0000	1.213
+++ symtab.c	23 Jul 2009 01:47:08 -0000
@@ -3243,6 +3243,8 @@ search_symbols (char *regexp, domain_enu
     {
       ALL_MSYMBOLS (objfile, msymbol)
       {
+        QUIT;
+
 	if (MSYMBOL_TYPE (msymbol) == ourtype ||
 	    MSYMBOL_TYPE (msymbol) == ourtype2 ||
 	    MSYMBOL_TYPE (msymbol) == ourtype3 ||


             reply	other threads:[~2009-07-23  1:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-23 12:09 Paul Pluzhnikov [this message]
2009-07-23 16:31 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090723015805.BD0F076BC0@localhost \
    --to=ppluzhnikov@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox