Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@redhat.com>,
		Vladimir Prus <vladimir@codesourcery.com>
Subject: Re: Value reference counting
Date: Tue, 21 Jul 2009 18:18:00 -0000	[thread overview]
Message-ID: <20090721181337.GC11667@caradoc.them.org> (raw)
In-Reply-To: <20090717184152.GA6863@caradoc.them.org>

On Fri, Jul 17, 2009 at 02:41:53PM -0400, Daniel Jacobowitz wrote:
> This patch, based on an old patch from Vladimir, implements reference
> counting for values.  Tom, this is the approach I discussed with you
> on IRC: instead of treating the value chain as a normal reference and
> using release_value to take references, this separates the value chain
> (which is boolean; a value is either on it or not) from references
> (which are counted).  So you take a reference with value_incref.
> release_value transforms the value chain's reference into a normal
> reference.  That's an entirely theoretical operation, by which I mean
> release_value doesn't have to do anything special.
> 
> Does this look OK?  Tom, will it work for the Python code?
> 
> Tested on x86_64-linux, no regressions.

I've checked this in with the revised comment.  The long-lived memory
usage issues Thiago commented on aren't related particularly to this
patch.

-- 
Daniel Jacobowitz
CodeSourcery


      parent reply	other threads:[~2009-07-21 18:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-17 19:03 Daniel Jacobowitz
2009-07-17 19:04 ` Tom Tromey
2009-07-17 19:25   ` Daniel Jacobowitz
2009-07-17 22:55     ` Tom Tromey
2009-07-20 13:30     ` Thiago Jung Bauermann
2009-07-20 13:34       ` Daniel Jacobowitz
2009-07-20 14:57         ` Thiago Jung Bauermann
2009-07-20 17:34       ` Tom Tromey
2009-07-20 19:45         ` Thiago Jung Bauermann
2009-07-20  9:55 ` Vladimir Prus
2009-07-20 13:40   ` Daniel Jacobowitz
2009-07-20 15:08     ` Vladimir Prus
2009-07-21 18:18 ` Daniel Jacobowitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090721181337.GC11667@caradoc.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox