From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3532 invoked by alias); 20 Jul 2009 15:08:20 -0000 Received: (qmail 3516 invoked by uid 22791); 20 Jul 2009 15:08:19 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mtagate3.de.ibm.com (HELO mtagate3.de.ibm.com) (195.212.29.152) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 20 Jul 2009 15:08:09 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate3.de.ibm.com (8.14.3/8.13.8) with ESMTP id n6KF7v0I154140 for ; Mon, 20 Jul 2009 15:07:57 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n6KF7uf12572346 for ; Mon, 20 Jul 2009 17:07:56 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n6KF7tPa005089 for ; Mon, 20 Jul 2009 17:07:56 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id n6KF7s5S005063; Mon, 20 Jul 2009 17:07:54 +0200 Message-Id: <200907201507.n6KF7s5S005063@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 20 Jul 2009 17:07:54 +0200 Subject: Re: [rfc] Fix register cache invalidation To: pedro@codesourcery.com (Pedro Alves) Date: Mon, 20 Jul 2009 15:14:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <200907201435.07453.pedro@codesourcery.com> from "Pedro Alves" at Jul 20, 2009 02:35:07 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00486.txt.bz2 Pedro Alves wrote: > On Tuesday 14 July 2009 15:59:28, Ulrich Weigand wrote: > > > when testing the Cell/B.E. combined debugger patches I ran into a situation > > where registers_changed was not called soon enough. > > > > A while ago I proposed a patch to simplify register invalidation (as part of > > a infrun cleanup series): > > http://sourceware.org/ml/gdb-patches/2008-12/msg00120.html > > This cleanup actually fixes the combined debugger problem as well. > > Curious. Are we sure we're not hidding some other bug then? Hmm, interestingly enough I cannot reproduce the problem I was seeing with the current combined debugger patches ... The problem I had was basically that during adjust_pc_after_break I was getting the wrong architecture (and thus the wrong decr_pc_after_break value) because the old architecture had been cached, and no registers_changed call happened in between. As the problem disappeared when applying the cleanup patch (which I'd intended to do anyway), I didn't investigate in more detail. Unfortunately, the underlying problem seems to have gone away anyway in the meantime ... > > At the time, Pedro pointed out that parts of that patch weren't safe in the > > non-stop case. The version below omits those parts, and only changes code > > to simplify calling registers_changed and resetting waiton_ptid. > > > Tested on powerpc64-linux with no regressions. > > Any comments? I'd like to commit this in a couple of days. > > I like it! OK, thanks for looking at the patch! I've checked this in now. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com