Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: Hui Zhu <teawater@gmail.com>
Cc: Marc Khouzam <marc.khouzam@ericsson.com>,
	 Michael Snyder <msnyder@vmware.com>,
	 Jan Kratochvil <jan.kratochvil@redhat.com>,
	 Joel Brobecker <brobecker@adacore.com>,
	 "gdb-patches ml" <gdb-patches@sourceware.org>
Subject: Re: Testing of reverse debug commands
Date: Mon, 20 Jul 2009 13:27:00 -0000	[thread overview]
Message-ID: <200907201416.25823.pedro@codesourcery.com> (raw)
In-Reply-To: <daef60380907122031la6c31c6oe752ae17db842933@mail.gmail.com>

On Monday 13 July 2009 04:31:37, Hui Zhu wrote:
> On Mon, Jul 13, 2009 at 03:25, Marc Khouzam<marc.khouzam@ericsson.com> wrote:
> >> Pedro Alves wrote:
> >> >
> >> > (gdb)
> >> > record stop
> >> > &"record stop\n"
> >> > ~"Process record is not started.\n"
> >> > ^done
> >> > (gdb)
> >>
> >> > So, I think some improvement would be nice for frontends.
> >>
> >> So, is this really an error?  Hui seems to have thought
> >> it wasn't.  Hui?  If it is, then it's just a matter of
> >> changing the corresponding printf_unfiltered calls in
> >> record.c to `error' calls (look for the "Process record
> >> is..." string).
> >> Then MI will get an ^error,msg="foo", instead of a ~"foo" + ^done.
> >
> > That would be more consistent for a frontend.  The frontend
> > can then decide if this should be reported as an error or simply
> > accepted.  But that is not such a big deal anymore, now that
> > you pointed out 'record' itself does report an error.
> >
> 
> I think the record's query and something is make a lot of troubles.
> I make a patch for it.  Please help me with it.

I got confused, since this isn't answering the question I asked.

This particular issue will be resolved when the query/nquery/yquery/MI
discussion reaches a conclusion, yes?  Or is this an independent change?
Do note that we have other CLI commands that query and default to
a "destructive" 'yes', like "run -> attach (kill?)", for example.
Maybe you should post this in its own new thread.

I think it would be nice if we crafted a GDB HIG.  Do we have
something of the sorts already?

-- 
Pedro Alves


  reply	other threads:[~2009-07-20 13:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4A5930EE.3040201@vmware.com>
     [not found] ` <4A5A19FC.9050206@vmware.com>
     [not found]   ` <6D19CA8D71C89C43A057926FE0D4ADAA07B71A36@ecamlmw720.eamcs.ericsson.se>
     [not found]     ` <200907122007.38248.pedro@codesourcery.com>
     [not found]       ` <6D19CA8D71C89C43A057926FE0D4ADAA07B71A3E@ecamlmw720.eamcs.ericsson.se>
2009-07-13  5:34         ` Hui Zhu
2009-07-20 13:27           ` Pedro Alves [this message]
2009-07-20 14:42             ` Hui Zhu
2009-07-21 20:20             ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200907201416.25823.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=marc.khouzam@ericsson.com \
    --cc=msnyder@vmware.com \
    --cc=teawater@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox