From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17172 invoked by alias); 20 Jul 2009 09:55:40 -0000 Received: (qmail 17160 invoked by uid 22791); 20 Jul 2009 09:55:37 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (140.186.70.10) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 20 Jul 2009 09:55:24 +0000 Received: from tschwinge by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1MSpab-000256-EJ; Mon, 20 Jul 2009 05:55:21 -0400 Date: Mon, 20 Jul 2009 12:07:00 -0000 From: Thomas Schwinge To: Pedro Alves Cc: gdb-patches@sourceware.org, bug-hurd@gnu.org Subject: Restore GNU/Hurd functionality (was: Modernize solaris threads support.) Message-ID: <20090720095521.GA5192@fencepost.gnu.org> References: <200902160549.49108.pedro@codesourcery.com> <200902231836.13188.pedro@codesourcery.com> <001201c9968c$ce7dab60$6b790220$@u-strasbg.fr> <200902241438.58802.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="liOOAslEiF7prFVr" Content-Disposition: inline In-Reply-To: <200902241438.58802.pedro@codesourcery.com> User-Agent: Mutt/1.5.11 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00467.txt.bz2 --liOOAslEiF7prFVr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 2995 Hello! On Tue, Feb 24, 2009 at 02:38:58PM +0000, Pedro Alves wrote: > On Tuesday 24 February 2009 14:33:05, Pierre Muller wrote: > > Pedro,=20 > > you also broke windows-nat.c compilation... >=20 > Uh! Darn it. [...] ... and another one (which I noticed only now...): when we recently got a new Debian gdb package, all attempts to use GDB on GNU/Hurd started failing like this: $ gdb /bin/true GNU gdb (GDB) 6.8.50.20090628-cvs-debian Copyright (C) 2009 Free Software Foundation, Inc. [...] (no debugging symbols found) (gdb) r Starting program: /bin/true=20 Segmentation fault > In any case, as I said before, I had to touch most *native* > configurations, so it's likelly that I missed several cases. If > you do spot one, the fix is *dead trivial*, so go ahead and commit a > fix as obvious ... You did change the ``extern gnu_store_registers'' and ``extern gnu_fetch_registers'' declarations in gnu-nat.c, but not their definitons in i386gnu-nat.c, which I have committed now (as obvious). Should we perhaps move these two declarations into a file that is #included from i386gnu-nat.c? gnu-nat.h perhaps? Index: ChangeLog =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/ChangeLog,v retrieving revision 1.10725 diff -u -p -r1.10725 ChangeLog --- ChangeLog 18 Jul 2009 23:35:30 -0000 1.10725 +++ ChangeLog 20 Jul 2009 09:50:16 -0000 @@ -1,3 +1,8 @@ +2009-07-20 Thomas Schwinge + + * i386gnu-nat.c (gnu_fetch_registers, gnu_store_registers): Adjust to + 2009-02-23 target_ops changes. + 2009-07-18 Michael Snyder =20 * infrun.c (handle_inferior_event): Remove an execution_direction Index: i386gnu-nat.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/i386gnu-nat.c,v retrieving revision 1.36 diff -u -p -r1.36 i386gnu-nat.c --- i386gnu-nat.c 3 Jan 2009 05:57:52 -0000 1.36 +++ i386gnu-nat.c 20 Jul 2009 09:50:16 -0000 @@ -111,7 +111,8 @@ supply_fpregset (struct regcache *regcac =20 /* Fetch register REGNO, or all regs if REGNO is -1. */ void -gnu_fetch_registers (struct regcache *regcache, int regno) +gnu_fetch_registers (struct target_ops *ops, + struct regcache *regcache, int regno) { struct proc *thread; =20 @@ -202,7 +203,8 @@ store_fpregs (const struct regcache *reg =20 /* Store at least register REGNO, or all regs if REGNO =3D=3D -1. */ void -gnu_store_registers (struct regcache *regcache, int regno) +gnu_store_registers (struct target_ops *ops, + struct regcache *regcache, int regno) { struct proc *thread; struct gdbarch *gdbarch =3D get_regcache_arch (regcache); Regards, Thomas --liOOAslEiF7prFVr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline Content-length: 191 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.2 (GNU/Linux) iD8DBQFKZD8JsmqaiQAHQR4RAlukAJ9RKu712rRk0eL7H92tLlGtHrAc9QCfZIhM wcYbFB3DhlPuJt+XTT9uHvI= =pX+G -----END PGP SIGNATURE----- --liOOAslEiF7prFVr--