From: Daniel Jacobowitz <drow@false.org>
To: Michael Snyder <msnyder@vmware.com>
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"teawater@gmail.com" <teawater@gmail.com>
Subject: Re: [RFA] epilogue unwinder for i386 (reverse 1/2)
Date: Mon, 13 Jul 2009 19:44:00 -0000 [thread overview]
Message-ID: <20090713194241.GA1287@caradoc.them.org> (raw)
In-Reply-To: <4A5B8B4B.4020903@vmware.com>
On Mon, Jul 13, 2009 at 12:30:19PM -0700, Michael Snyder wrote:
> You're right, bad judgement call on my part.
> I'll take it out again until this is resolved.
Thanks. Or we can just fix the test, since it sounds straightforward.
> The issue is, the test contains a hand-coded artificial signal
> frame/handler consisting of a single "ret" instruction.
>
> My new epilogue unwinder recognizes the "ret", so it lays
> claim to the frame before the dwarf unwinder has a chance.
>
> It still does a proper backtrace, but of course it doesn't
> show the <signal handler> tag, it just shows the function name.
>
> What do you think? Could we maybe add a nop here or something?
> I don't understand the details well enough to speculate.
That ought to work, with a comment about what it's there for.
Just don't push/pop to change the stack layout.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2009-07-13 19:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-04 0:26 Michael Snyder
2009-07-04 0:37 ` Michael Snyder
2009-07-05 10:54 ` Hui Zhu
2009-07-05 12:36 ` Mark Kettenis
2009-07-05 18:49 ` Daniel Jacobowitz
2009-07-05 20:46 ` Michael Snyder
2009-07-05 21:12 ` Daniel Jacobowitz
2009-07-05 20:58 ` Michael Snyder
2009-07-11 20:19 ` Michael Snyder
2009-07-12 17:07 ` Mark Kettenis
2009-07-12 17:53 ` Michael Snyder
2009-07-13 4:55 ` drow
2009-07-13 19:43 ` Michael Snyder
2009-07-13 19:44 ` Daniel Jacobowitz [this message]
2009-07-13 20:28 ` Michael Snyder
2009-07-13 20:20 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090713194241.GA1287@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=msnyder@vmware.com \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox